Started by user Pooja RavipoojaPooja Ravi104c7679e7b9c80b89ea503c28608711ef175a6ba34c7679e7b9c80b89ea503c28608711ef175a6ba3refs/remotes/origin/main-maestro-cloud-run4c7679e7b9c80b89ea503c28608711ef175a6ba34c7679e7b9c80b89ea503c28608711ef175a6ba3refs/remotes/origin/main-maestro-cloud-run311b858342ed1877d987422a87b22c30028dc341101b858342ed1877d987422a87b22c30028dc34110refs/remotes/origin/main1b858342ed1877d987422a87b22c30028dc341101b858342ed1877d987422a87b22c30028dc34110refs/remotes/origin/main1b858342ed1877d987422a87b22c30028dc341101b858342ed1877d987422a87b22c30028dc34110refs/remotes/origin/mainhttps://github.com/UstadMobile/Respect.githttps://devserver3.ustadmobile.com/jenkins/job/RESPECT-end-to-end/31/artifacthttps://devserver3.ustadmobile.com/jenkins/job/RESPECT-end-to-end/changeshttps://devserver3.ustadmobile.com/jenkins/job/RESPECT-end-to-end/31/https://devserver3.ustadmobile.com/jenkins/job/RESPECT-end-to-end/31/testReportfalse#3110604001580838RESPECT-end-to-end #3131falsefalse314161FAILURE1762758862444https://devserver3.ustadmobile.com/jenkins/job/RESPECT-end-to-end/31/- respect-lib-shared/src/commonMain/composeResources/values/strings.xmlrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.ktgradle/libs.versions.tomlrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/validateemail/ValidateEmailUseCase.kt5e149402d39d01e6ec9ce36ae49a23a1573ad2851761116355000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgfeat: Validate date of birth on save
This commit introduces validation to prevent the date of birth from being in the future. The validation is now handled in the `PersonEditViewModel` when the save button is clicked, rather than restricting the date selection in the UI.
Key changes:
- Removed the future date restriction from the `RespectLocalDateField` date picker, allowing users to select any date.
- Added a new string resource `date_of_birth_in_future` for the error message.
- Updated `PersonEditViewModel` to validate the date of birth upon saving. If the selected date is in the future, an error message is displayed and the save is aborted.
- Modified `PersonEditScreen` to display the date of birth validation error message below the input field.
2025-10-22 12:29:15 +05305e149402d39d01e6ec9ce36ae49a23a1573ad285feat: Validate date of birth on saveaddrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/validateemail/ValidateEmailUseCase.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kteditgradle/libs.versions.tomleditrespect-lib-shared/src/commonMain/composeResources/values/strings.xmleditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt
- respect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/PersonExt.kta281e9ecc4a9774b415f5be4a65261bc42fc32191761121700000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgrefactor: Improve `fullName` generation in `PersonExt`
This commit refactors the `fullName` extension function for the `Person` model to more robustly handle whitespace and optional name parts.
The function now trims leading/trailing whitespace from `givenName`, `middleName`, and `familyName`. It also ensures that spaces are only added between name parts if the preceding part is not empty, preventing extra spaces in the final output.
2025-10-22 13:58:20 +0530a281e9ecc4a9774b415f5be4a65261bc42fc3219refactor: Improve `fullName` generation in `PersonExt`editrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/PersonExt.kt
- respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.ktf8fea3845d7c67a49aad982df18c113f30e474e81761122152000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgfeat: Clear email error on change
This commit clears the email validation error message in the `PersonEditViewModel` when the user modifies the email address. The phone number error handling already had similar logic, and this change makes the email field consistent.
2025-10-22 14:05:52 +0530f8fea3845d7c67a49aad982df18c113f30e474e8feat: Clear email error on changeeditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt
- respect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt74b2f944d1230e5fd55316ba473d9a4a1c2ade7f1761219231000https://devserver3.ustadmobile.com/jenkins/user/nikunj.sharmanikunj.sharmanikunj.sharma@sutara.orgcommit
2025-10-23 17:03:51 +053074b2f944d1230e5fd55316ba473d9a4a1c2ade7fcommiteditrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt
- respect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/PersonExt.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.ktb7ca8abb109f3d97b7f4af365f0a5a3474c3556d1761219565000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgIf Using family name it is duplicating the other family name and middle name so changed to given name
2025-10-23 17:09:25 +0530b7ca8abb109f3d97b7f4af365f0a5a3474c3556dIf Using family name it is duplicating the other family name and middle name so changed to given nameeditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/PersonExt.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt
- respect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.ktrespect-lib-shared/src/commonMain/composeResources/values/strings.xmlrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt21f0337b914b017d984896d30b577a42e4c58d571761557109000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgfeat: Enhance ClazzDetailScreen with more information
This commit updates the class details screen to provide more comprehensive information about the class and its pending members.
Key changes:
- Displays the class description in the `TopAppBar`.
- Shows a count of pending teacher and student requests in the "Pending requests" section header.
- For pending teachers and students, the list now shows their role (teacher or student), gender, and date of birth.
- In the class edit screen, the `*` indicating a required field has been removed from the "Class Name" label to simplify the UI.
2025-10-27 14:55:09 +053021f0337b914b017d984896d30b577a42e4c58d57feat: Enhance ClazzDetailScreen with more informationeditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kteditrespect-lib-shared/src/commonMain/composeResources/values/strings.xmleditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt
- .maestro/flows-in-progress/001_001_invite_using_invite_code_test.yaml.maestro/flows/001_002_add_user_direct_test.yamlc181fd69bd4464a339a0d20aa562760cf27818b01762338600000https://devserver3.ustadmobile.com/jenkins/user/poojaPooja Ravipooja@ustadmobile.comUpdated test
2025-11-05 14:30:00 +0400c181fd69bd4464a339a0d20aa562760cf27818b0Updated testedit.maestro/flows-in-progress/001_001_invite_using_invite_code_test.yamledit.maestro/flows/001_002_add_user_direct_test.yaml
- respect-lib-shared/src/commonMain/composeResources/values/strings.xmlrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.ktbaa66c60f3cad741ab08547fcaad4dfb11c434a31762359975000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgrefactor: Use fullName for person display and internationalize labels
This commit updates the `ClazzDetailScreen` to use the `person.fullName()` extension function for displaying user names, ensuring a consistent format. It also replaces hardcoded text labels for "Gender" and "DOB" with internationalized string resources.
2025-11-05 21:56:15 +0530baa66c60f3cad741ab08547fcaad4dfb11c434a3refactor: Use fullName for person display and internationalize labelseditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kteditrespect-lib-shared/src/commonMain/composeResources/values/strings.xmleditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt
- respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt8e1da350c253cf76bbe63330e7bdccba3af09e1d1762409241000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgchore: Fix Kotlin linting issues
This commit addresses several Kotlin linting errors by removing unnecessary whitespace. The changes include:
- Removing space before `else` keywords.
- Fixing spacing around commas.
- Removing space before `if` conditions.
2025-11-06 11:37:21 +05308e1da350c253cf76bbe63330e7bdccba3af09e1dchore: Fix Kotlin linting issueseditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt
- respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/detail/PersonDetailScreen.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt11f753affc07d7a0a84720faa0a2be2b10ce4fad1762414200000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgfeat: Make email optional for persons
This commit updates the validation and display logic to correctly handle cases where a person's email is not provided.
2025-11-06 13:00:00 +053011f753affc07d7a0a84720faa0a2be2b10ce4fadfeat: Make email optional for personseditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/detail/PersonDetailScreen.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt
- respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.ktac4cd32c2d0dc354fc19e472431f6408d3ca44ad1762416457000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgfeat: Add validation for first and last name
This commit introduces validation to ensure that the first and last name fields are not blank when editing a person's details.
2025-11-06 13:37:37 +0530ac4cd32c2d0dc354fc19e472431f6408d3ca44adfeat: Add validation for first and last nameeditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt
- respect-lib-shared/src/jvmTest/kotlin/world/respect/domain/validateemail/ValidateEmailUseCaseTest.kt70bf7b3436bcedab2807f7ca724ffc88bb0f4aa61762420972000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgfeat: Add validation for first and last name
This commit introduces validation to ensure that the first and last name fields are not blank when editing a person's details.
2025-11-06 14:52:52 +053070bf7b3436bcedab2807f7ca724ffc88bb0f4aa6feat: Add validation for first and last nameaddrespect-lib-shared/src/jvmTest/kotlin/world/respect/domain/validateemail/ValidateEmailUseCaseTest.kt
- .maestro/flows/001_002_add_user_direct_test.yamla8b21cd7d6916369a5a2ccdc4d0c4c6f8a0282a81762421097000https://devserver3.ustadmobile.com/jenkins/user/poojaPooja Ravipooja@ustadmobile.comUpdated mandatory test
2025-11-06 13:24:57 +0400a8b21cd7d6916369a5a2ccdc4d0c4c6f8a0282a8Updated mandatory testedit.maestro/flows/001_002_add_user_direct_test.yaml
- respect-lib-shared/src/jvmTest/kotlin/world/respect/domain/validateemail/ValidateEmailUseCaseTest.ktff80e4fe637141b36e081ca29aaa23796180448c1762421140000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgstyle: Standardize test function naming
This commit updates the test function names in `ValidateEmailUseCaseTest.kt` to follow the camelCase convention, removing backticks and descriptive phrases.
2025-11-06 14:55:40 +0530ff80e4fe637141b36e081ca29aaa23796180448cstyle: Standardize test function namingeditrespect-lib-shared/src/jvmTest/kotlin/world/respect/domain/validateemail/ValidateEmailUseCaseTest.kt
- respect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectGenderExposedDropDownMenuField.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/signup/SignUpScreen.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt009bbd68b1685ef1641dde338b8c9a874798b6791762499460000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgrefactor: Standardize required field validation message
This commit replaces the generic `required` string resource with a more specific `required_field` resource for consistency in validation error messages.
Key changes:
- In `PersonEditViewModel`, the validation logic for first name, last name, and gender now uses `Res.string.required_field`.
- The `PersonEditScreen` and `RespectGenderExposedDropDownMenuField` have been updated to display the specific validation error message from the view model state, falling back to a default required text.
- The gender dropdown component now accepts and displays a `UiText` error message, improving how validation feedback is presented to the user on both the Person Edit and Sign Up screens.
2025-11-07 12:41:00 +0530009bbd68b1685ef1641dde338b8c9a874798b679refactor: Standardize required field validation messageeditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/signup/SignUpScreen.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectGenderExposedDropDownMenuField.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt
- respect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/edit/ClazzEditViewModel.kt9c81891a175e84699f416730355f7f6ea8bce39d1762501011000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgrefactor: Use UiText for class name validation
This commit updates the class name validation to use `UiText` instead of a plain `String`. This allows for more flexible and localized error messages.
Key changes:
- `ClazzEditUiState.clazzNameError` is now of type `UiText?`.
- The `ClazzEditViewModel` now sets `clazzNameError` to a `UiText` from string resources.
- `ClazzEditScreen` has been updated to use `uiTextStringResource` to display the localized validation message.
- The resource string for the class name label was changed from `class_name` to `name` for consistency.
2025-11-07 13:06:51 +05309c81891a175e84699f416730355f7f6ea8bce39drefactor: Use UiText for class name validationeditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/edit/ClazzEditViewModel.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt
- respect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectGenderExposedDropDownMenuField.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt3e27825471fa9dd4a06ed125fcf2052df2650b421762501308000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgchore: Format code for consistency
This commit applies minor code formatting changes to improve consistency across the codebase. Specifically, it adjusts spacing around operators and in conditional statements.
2025-11-07 13:11:48 +05303e27825471fa9dd4a06ed125fcf2052df2650b42chore: Format code for consistencyeditrespect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectGenderExposedDropDownMenuField.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt
- respect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/detail/PersonDetailScreen.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt079da7e476b8ed4d8bf01d23175549c97aef0ec61762757866000https://devserver3.ustadmobile.com/jenkins/user/mikeMike Dawsonmike@ustadmobile.comMinor tidy changes:
1) Remove personedit padding on column - each field has its own padding
2) Remove "dob" as a string - this is short, but not clear.
2025-11-10 10:57:46 +0400079da7e476b8ed4d8bf01d23175549c97aef0ec6Minor tidy changes:editrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/detail/PersonDetailScreen.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt
githttps://devserver3.ustadmobile.com/jenkins/user/nikunj.sharmanikunj.sharmanikunj.sharmahttps://devserver3.ustadmobile.com/jenkins/user/mikeMike Dawsonmikehttps://devserver3.ustadmobile.com/jenkins/user/poojaPooja Ravipoojahttps://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma