Skip to content
Success

Changes

Summary

  1. addchild usecase added (commit: 4e70835) (details)
  2. CHANGES relatd to adding child (commit: e1374d6) (details)
  3. CHANGES relatd to adding child (commit: f0aa944) (details)
  4. user-signup-e2e (commit: 531514b) (details)
  5. crash fix (commit: 4c8dab8) (details)
  6. added clearstate (commit: ad0dc93) (details)
  7. added teardown (commit: ff9209d) (details)
  8. Gender commented (commit: 8437330) (details)
  9. corrected (commit: 8a838a4) (details)
  10. https://github.com/UstadMobile/Respect/issues/57 (commit: 9ef4c49) (details)
  11. account list not scrollable fixed (commit: cbb8aae) (details)
  12. Added mandatory field test (commit: a83dcee) (details)
  13. ~/StudioProjects/RespectTest/respect-server/log - will getignore (commit: 6678f7d) (details)
  14. fix for issue 76 (commit: 82c50c2) (details)
  15. test tag added (commit: 67df22b) (details)
  16. commented mandatory field tests (commit: a17c57a) (details)
  17. Added hideKeyboard command (commit: e81f48d) (details)
  18. Added teacher flow test (commit: bea7e42) (details)
  19. update test (commit: 30950be) (details)
  20. duplicate string remove (commit: d3d8127) (details)
  21. updated test flow - single test (commit: f509e4f) (details)
  22. updated to password* (commit: c2e3286) (details)
  23. merged with main (commit: 93eafde) (details)
  24. updated to date of birth field (commit: 9c70cef) (details)
  25. Gender and DOB manadatory field tests (commit: 5004d71) (details)
  26. DOB can't be future date - test added (commit: 5bd55d5) (details)
  27. DOB updated test (commit: 7276679) (details)
  28. changes in SignupViewModel.kt (commit: 52b0310) (details)
  29. updated student name and flow change (commit: e27d0c4) (details)
  30. changes in SignupViewModel.kt (commit: b8eb4a2) (details)
  31. changes in SignupViewModel.kt (commit: c107200) (details)
  32. changes AddChildAccountUseCase.kt (commit: 5c27b3a) (details)
  33. commented DownloadIntegrationTest.kt as it contain error (commit: ee3fab9) (details)
  34. feat: Validate date of birth on save (commit: 5e14940) (details)
  35. refactor: Improve `fullName` generation in `PersonExt` (commit: a281e9e) (details)
  36. feat: Clear email error on change (commit: f8fea38) (details)
  37. commit (commit: 74b2f94) (details)
  38. If Using family name it is duplicating the other family name and middle name so changed to given name (commit: b7ca8ab) (details)
  39. Restore deleted Maestro flow test not related to this branch (commit: d79ec34) (details)
  40. Restore deleted Maestro flow file 004_create_report_test.yaml (commit: 51e018b) (details)
  41. feat: Enhance ClazzDetailScreen with more information (commit: 21f0337) (details)
  42. Updated test flow (commit: 99aa0a4) (details)
  43. Updated setDate.js file (commit: 4582356) (details)
  44. updated to main (commit: f1c5659) (details)
  45. updated mandatory field error (commit: 712bb5a) (details)
  46. string change (commit: cdd7571) (details)
  47. string change (commit: 79b1be5) (details)
  48. string change (commit: 2a1eadd) (details)
  49. Updated test (commit: c181fd6) (details)
  50. refactor: Use fullName for person display and internationalize labels (commit: baa66c6) (details)
  51. chore: Fix Kotlin linting issues (commit: 8e1da35) (details)
  52. feat: Make email optional for persons (commit: 11f753a) (details)
  53. feat: Add validation for first and last name (commit: ac4cd32) (details)
  54. Make ResultDest its own class so that it can support two types of return destinations: KClass based and route based. (commit: 0e617de) (details)
  55. feat: Add validation for first and last name (commit: 70bf7b3) (details)
  56. Updated mandatory test (commit: a8b21cd) (details)
  57. style: Standardize test function naming (commit: ff80e4f) (details)
  58. Update AssignmentEditViewModel to use route based result destination. (commit: e90f937) (details)
  59. Add navigation return result support for selecting a person. (commit: 8d0112f) (details)
  60. refactor: Standardize required field validation message (commit: 009bbd6) (details)
  61. refactor: Use UiText for class name validation (commit: 9c81891) (details)
  62. chore: Format code for consistency (commit: 3e27825) (details)
  63. Put invite code on PersonList and remove AddPersonToClazz . (commit: f17e99e) (details)
  64. Fix select person from list. Initial implementation of adding to class. (commit: 5b7560c) (details)
  65. Fix EnrollmentEntity for database (commit: 8c2c554) (details)
  66. Update PersonListScreen to make it easier for the Maestro test to get the invite code. (commit: 66f6df5) (details)
  67. Minor tidy changes: (commit: 079da7e) (details)
  68. updated copy-paste - invite code (commit: 67f40be) (details)
  69. Remove class_name_label string and change admin_add_app_and_teacher to use name not class name. (commit: e56d3cd) (details)
  70. Fix labels on 001_001 invite test to match those currently used (commit: e8f86da) (details)
  71. Fix label match admin_add_app_and_teacher (commit: 7f3cdea) (details)
  72. Fix lesson selection flow to use RouteResultDest (commit: ad70644) (details)
The file was addedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCaseDb.kt
The file was modifiedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/invite/RedeemInviteUseCaseDb.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/Application.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCase.kt
The file was addedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/util/toPerson.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCaseClient.kt
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/ServerKoinModule.kt (diff)
The file was addedrespect-server/src/main/kotlin/world/respect/server/routes/school/respect/AddChildAccountRoute.kt
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/RespectSchoolDatabase.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCaseClient.kt (diff)
The file was modifiedrespect-datalayer-db/schemas/world.respect.datalayer.db.RespectSchoolDatabase/7.json (diff)
The file was addedrespect-datalayer-db/schemas/world.respect.datalayer.db.RespectSchoolDatabase/8.json
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCase.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/routes/school/respect/AddChildAccountRoute.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/entities/PersonRelatedPersonEntity.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/RespectSchoolDatabaseMigrations.kt (diff)
The file was modifiedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCaseDb.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/ServerKoinModule.kt (diff)
The file was removedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCaseClient.kt
The file was removedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCaseDb.kt
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/toPerson.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/Application.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was removedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/util/toPerson.kt
The file was removedrespect-server/src/main/kotlin/world/respect/server/routes/school/respect/AddChildAccountRoute.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCase.kt (diff)
The file was modified.maestro/flows/subflows/school_admin_login_flow.yaml (diff)
The file was removed.maestro/flows-in-progress/001_003_student_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows-in-progress/001_004_user_login_via_invite_link_and_browse_lessons_test.yaml
The file was removed.maestro/flows-in-progress/003_create_classes_test.yaml
The file was added.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml
The file was added.maestro/flows/001_003_student_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows-in-progress/001_002_Parent_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows-in-progress/001_001_user_login_to _app_with_school_name_test.yaml
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
The file was modified.maestro/flows/subflows/school_admin_login_flow.yaml (diff)
The file was modified.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml (diff)
The file was modified.maestro/flows/001_003_student_user_join_class_using_invitecode_test.yaml (diff)
The file was modified.maestro/flows/001_003_student_user_join_class_using_invitecode_test.yaml (diff)
The file was modified.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml (diff)
The file was modified.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml (diff)
Commit 9ef4c495c7569ce306550e8b9f2d699dcfe47ed1 by nikunj.sharma
https://github.com/UstadMobile/Respect/issues/57
fixed
(commit: 9ef4c49)
The file was modifiedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/invite/RedeemInviteUseCaseDb.kt (diff)
Commit cbb8aaecfd425c833fbd330b012756438a36e563 by nikunj.sharma
account list not scrollable fixed
(commit: cbb8aae)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/accountlist/AccountListScreen.kt (diff)
The file was modified.maestro/flows/subflows/setDate.js (diff)
The file was modified.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml (diff)
The file was modified.maestro/flows/001_003_student_user_join_class_using_invitecode_test.yaml (diff)
Commit 6678f7d9ea006667edd9200a2337ca50e29f8995 by Pooja Ravi
~/StudioProjects/RespectTest/respect-server/log - will getignore
(commit: 6678f7d)
The file was modifiedrespect-server/.gitignore (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/signup/SignUpScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/signup/SignUpScreen.kt (diff)
Commit a17c57a925ac984812806581558e0453401af380 by Pooja Ravi
commented mandatory field tests
(commit: a17c57a)
The file was modified.maestro/flows/001_003_student_user_join_class_using_invitecode_test.yaml (diff)
The file was modified.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml (diff)
The file was modified.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml (diff)
The file was added.maestro/flows/001_005_teacher_user_join_class_using_invitecode_test.yaml
The file was modified.maestro/flows/001_003_student_user_join_class_using_invitecode_test.yaml (diff)
The file was modified.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml (diff)
The file was modified.maestro/flows/001_005_teacher_user_join_class_using_invitecode_test.yaml (diff)
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/enterpasswordsignup/EnterPasswordSignUpViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
The file was modifiedrespect-datalayer-db/schemas/world.respect.datalayer.db.RespectSchoolDatabase/8.json (diff)
Commit f509e4f2de541a3acbaba727b7fba1adaa024f5e by Pooja Ravi
updated test flow - single test
(commit: f509e4f)
The file was added.maestro/flows/001_002_admin_add_class_and_members_test.yaml
The file was removed.maestro/flows/001_003_student_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows-in-progress/004_create_report_test.yaml
The file was removed.maestro/flows/001_005_teacher_user_join_class_using_invitecode_test.yaml
The file was modified.maestro/flows/001_002_admin_add_class_and_members_test.yaml (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)
Commit 9c70cefe0be1f0334a93ce234cc201731c1e30e2 by Pooja Ravi
updated to date of birth field
(commit: 9c70cef)
The file was modified.maestro/flows/001_002_admin_add_class_and_members_test.yaml (diff)
Commit 5004d7112c9391cee0894fbda30de53d45fb8722 by Pooja Ravi
Gender and DOB manadatory field tests
(commit: 5004d71)
The file was modified.maestro/flows/001_002_admin_add_class_and_members_test.yaml (diff)
Commit 5bd55d5f7927390dae04be3948effa0c1c96712e by Pooja Ravi
DOB can't be future date - test added
(commit: 5bd55d5)
The file was modified.maestro/flows/001_002_admin_add_class_and_members_test.yaml (diff)
The file was modified.maestro/flows/001_002_admin_add_class_and_members_test.yaml (diff)
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/enterpasswordsignup/EnterPasswordSignUpViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
Commit e27d0c45523a70b7fab40516cf1833ec64821490 by Pooja Ravi
updated student name and flow change
(commit: e27d0c4)
The file was modified.maestro/flows/001_002_admin_add_class_and_members_test.yaml (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCase.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/daos/EnrollmentEntityDao.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
Commit 5c27b3a005a6b87fc70cd1c67a9f2ae7890bc52c by nikunj.sharma
changes AddChildAccountUseCase.kt
(commit: 5c27b3a)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCase.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/ServerKoinModule.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/daos/EnrollmentEntityDao.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCaseClient.kt
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/Application.kt (diff)
The file was addedrespect-server/src/main/kotlin/world/respect/server/routes/school/respect/AddChildAccountRoute.kt
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was addedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/addchild/AddChildAccountUseCaseDb.kt
Commit ee3fab9a4224f3eff93307dcaea1bc5d94bcff0c by nikunj.sharma
commented DownloadIntegrationTest.kt as it contain error
(commit: ee3fab9)
The file was modifiedrespect-lib-cache/src/jvmTest/kotlin/com/ustadmobile/libcache/downloader/DownloadIntegrationTest.kt (diff)
Commit 5e149402d39d01e6ec9ce36ae49a23a1573ad285 by mandvi.verma
feat: Validate date of birth on save

This commit introduces validation to prevent the date of birth from being in the future. The validation is now handled in the `PersonEditViewModel` when the save button is clicked, rather than restricting the date selection in the UI.

Key changes:
- Removed the future date restriction from the `RespectLocalDateField` date picker, allowing users to select any date.
- Added a new string resource `date_of_birth_in_future` for the error message.
- Updated `PersonEditViewModel` to validate the date of birth upon saving. If the selected date is in the future, an error message is displayed and the save is aborted.
- Modified `PersonEditScreen` to display the date of birth validation error message below the input field.
(commit: 5e14940)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt (diff)
The file was modifiedgradle/libs.versions.toml (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/validateemail/ValidateEmailUseCase.kt
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
Commit a281e9ecc4a9774b415f5be4a65261bc42fc3219 by mandvi.verma
refactor: Improve `fullName` generation in `PersonExt`

This commit refactors the `fullName` extension function for the `Person` model to more robustly handle whitespace and optional name parts.

The function now trims leading/trailing whitespace from `givenName`, `middleName`, and `familyName`. It also ensures that spaces are only added between name parts if the preceding part is not empty, preventing extra spaces in the final output.
(commit: a281e9e)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/PersonExt.kt (diff)
Commit f8fea3845d7c67a49aad982df18c113f30e474e8 by mandvi.verma
feat: Clear email error on change

This commit clears the email validation error message in the `PersonEditViewModel` when the user modifies the email address. The phone number error handling already had similar logic, and this change makes the email field consistent.
(commit: f8fea38)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
Commit b7ca8abb109f3d97b7f4af365f0a5a3474c3556d by mandvi.verma
If Using family name it is duplicating the other family name and middle name so changed to given name
(commit: b7ca8ab)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/PersonExt.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt (diff)
Commit d79ec348b732e6d2a785f574f4516f431e7eb6a5 by Pooja Ravi
Restore deleted Maestro flow test not related to this branch
(commit: d79ec34)
The file was added.maestro/flows-in-progress/001_004_user_login_via_invite_link_and_browse_lessons_test.yaml
The file was added.maestro/flows-in-progress/001_001_user_login_to _app_with_school_name_test.yaml
The file was added.maestro/flows-in-progress/003_create_classes_test.yaml
Commit 51e018b1e07466605e88fa6e7bb7561385ddd67c by Pooja Ravi
Restore deleted Maestro flow file 004_create_report_test.yaml
(commit: 51e018b)
The file was added.maestro/flows-in-progress/004_create_report_test.yaml
Commit 21f0337b914b017d984896d30b577a42e4c58d57 by mandvi.verma
feat: Enhance ClazzDetailScreen with more information

This commit updates the class details screen to provide more comprehensive information about the class and its pending members.

Key changes:
- Displays the class description in the `TopAppBar`.
- Shows a count of pending teacher and student requests in the "Pending requests" section header.
- For pending teachers and students, the list now shows their role (teacher or student), gender, and date of birth.
- In the class edit screen, the `*` indicating a required field has been removed from the "Class Name" label to simplify the UI.
(commit: 21f0337)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
The file was added.maestro/flows/001_001_invite_using_invite_code_test.yaml
The file was removed.maestro/flows/001_002_admin_add_class_and_members_test.yaml
The file was modified.maestro/flows/subflows/setDate.js (diff)
The file was modified.maestro/flows/001_001_invite_using_invite_code_test.yaml (diff)
The file was removed.maestro/flows-in-progress/001_001_invite_using_invite_code_test.yaml
Commit 712bb5ab5fdf8a3f357887cdcd8b98e603c194de by Pooja Ravi
updated mandatory field error
(commit: 712bb5a)
The file was modified.maestro/flows/001_001_invite_using_invite_code_test.yaml (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/createaccount/CreateAccountScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/signup/SignUpScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/enterpasswordsignup/EnterPasswordSignUpViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/enterpasswordsignup/EnterPasswordSignUpScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/changepassword/ChangePasswordScreen.kt (diff)
The file was modifiedrespect-datalayer-db/schemas/world.respect.datalayer.db.RespectSchoolDatabase/8.json (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/signup/CreateAccountViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectGenderExposedDropDownMenuField.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/edit/ClazzEditViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/createaccount/CreateAccountScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectGenderExposedDropDownMenuField.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/signup/SignUpScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/enterpasswordsignup/EnterPasswordSignUpScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/changepassword/ChangePasswordScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectGenderExposedDropDownMenuField.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/edit/ClazzEditViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt (diff)
The file was modified.maestro/flows-in-progress/001_001_invite_using_invite_code_test.yaml (diff)
The file was modified.maestro/flows/001_002_add_user_direct_test.yaml (diff)
Commit baa66c60f3cad741ab08547fcaad4dfb11c434a3 by mandvi.verma
refactor: Use fullName for person display and internationalize labels

This commit updates the `ClazzDetailScreen` to use the `person.fullName()` extension function for displaying user names, ensuring a consistent format. It also replaces hardcoded text labels for "Gender" and "DOB" with internationalized string resources.
(commit: baa66c6)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt (diff)
Commit 8e1da350c253cf76bbe63330e7bdccba3af09e1d by mandvi.verma
chore: Fix Kotlin linting issues

This commit addresses several Kotlin linting errors by removing unnecessary whitespace. The changes include:
- Removing space before `else` keywords.
- Fixing spacing around commas.
- Removing space before `if` conditions.
(commit: 8e1da35)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)
Commit 11f753affc07d7a0a84720faa0a2be2b10ce4fad by mandvi.verma
feat: Make email optional for persons

This commit updates the validation and display logic to correctly handle cases where a person's email is not provided.
(commit: 11f753a)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/detail/PersonDetailScreen.kt (diff)
Commit ac4cd32c2d0dc354fc19e472431f6408d3ca44ad by mandvi.verma
feat: Add validation for first and last name

This commit introduces validation to ensure that the first and last name fields are not blank when editing a person's details.
(commit: ac4cd32)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt (diff)
Commit 0e617de0e45c178bb4af7403d3e794b2b0243553 by Mike Dawson
Make ResultDest its own class so that it can support two types of return destinations: KClass based and route based.
(commit: 0e617de)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/AppRoutes.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/KClassStringSerializer.kt
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/app/App.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/detail/AppsDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/NavResultReturnerExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/edit/AssignmentEditViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/list/LearningUnitListViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/RouteWithResultDest.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/launcher/AppLauncherViewModel.kt (diff)
Commit 70bf7b3436bcedab2807f7ca724ffc88bb0f4aa6 by mandvi.verma
feat: Add validation for first and last name

This commit introduces validation to ensure that the first and last name fields are not blank when editing a person's details.
(commit: 70bf7b3)
The file was addedrespect-lib-shared/src/jvmTest/kotlin/world/respect/domain/validateemail/ValidateEmailUseCaseTest.kt
The file was modified.maestro/flows/001_002_add_user_direct_test.yaml (diff)
Commit ff80e4fe637141b36e081ca29aaa23796180448c by mandvi.verma
style: Standardize test function naming

This commit updates the test function names in `ValidateEmailUseCaseTest.kt` to follow the camelCase convention, removing backticks and descriptive phrases.
(commit: ff80e4f)
The file was modifiedrespect-lib-shared/src/jvmTest/kotlin/world/respect/domain/validateemail/ValidateEmailUseCaseTest.kt (diff)
Commit e90f937cdd1227a0d6605af0c846f7dee9a42961 by Mike Dawson
Update AssignmentEditViewModel to use route based result destination.
(commit: e90f937)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/edit/AssignmentEditViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/RouteWithResultDest.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/NavResultReturnerExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/NavResultReturner.kt (diff)
Commit 8d0112fcb1761a824d030a9ec7aff853fea92651 by Mike Dawson
Add navigation return result support for selecting a person.
(commit: 8d0112f)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/daos/PersonEntityDao.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/PersonDataSourceDb.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/AppRoutes.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/list/PersonListViewModel.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/PersonDataSource.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/RouteWithResultDestExt.kt
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/list/PersonListScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/detail/PersonDetailViewModel.kt (diff)
Commit 009bbd68b1685ef1641dde338b8c9a874798b679 by mandvi.verma
refactor: Standardize required field validation message

This commit replaces the generic `required` string resource with a more specific `required_field` resource for consistency in validation error messages.

Key changes:
- In `PersonEditViewModel`, the validation logic for first name, last name, and gender now uses `Res.string.required_field`.
- The `PersonEditScreen` and `RespectGenderExposedDropDownMenuField` have been updated to display the specific validation error message from the view model state, falling back to a default required text.
- The gender dropdown component now accepts and displays a `UiText` error message, improving how validation feedback is presented to the user on both the Person Edit and Sign Up screens.
(commit: 009bbd6)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectGenderExposedDropDownMenuField.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/signup/SignUpScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt (diff)
Commit 9c81891a175e84699f416730355f7f6ea8bce39d by mandvi.verma
refactor: Use UiText for class name validation

This commit updates the class name validation to use `UiText` instead of a plain `String`. This allows for more flexible and localized error messages.

Key changes:
- `ClazzEditUiState.clazzNameError` is now of type `UiText?`.
- The `ClazzEditViewModel` now sets `clazzNameError` to a `UiText` from string resources.
- `ClazzEditScreen` has been updated to use `uiTextStringResource` to display the localized validation message.
- The resource string for the class name label was changed from `class_name` to `name` for consistency.
(commit: 9c81891)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/edit/ClazzEditViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt (diff)
Commit 3e27825471fa9dd4a06ed125fcf2052df2650b42 by mandvi.verma
chore: Format code for consistency

This commit applies minor code formatting changes to improve consistency across the codebase. Specifically, it adjusts spacing around operators and in conditional statements.
(commit: 3e27825)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectGenderExposedDropDownMenuField.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt (diff)
Commit f17e99e2a535e7a0fc436e7565de9270a57880d7 by Mike Dawson
Put invite code on PersonList and remove AddPersonToClazz .
(commit: f17e99e)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/AppRoutes.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/list/PersonListScreen.kt (diff)
The file was removedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/addperson/AddPersonToClazzViewModel.kt
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/app/AppNavHost.kt (diff)
The file was removedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/addperson/AddPersonToClazzScreen.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/list/PersonListViewModel.kt (diff)
Commit 5b7560cde286ef4e42d8cf07fd8ef47529c8b31b by Mike Dawson
Fix select person from list. Initial implementation of adding to class.
(commit: 5b7560c)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/list/PersonListViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/EnrollmentDataSourceDb.kt (diff)
Commit 8c2c5547d4124ec56dea96df08d95e42a9b08471 by Mike Dawson
Fix EnrollmentEntity for database

EnrollmentEntity did not store the full uid string of the related class and person, it was relying on a join to the class and person entity. This fails when attempting to create a pending enrollment for a student who profile which is being created as part of a parental registration (on the client).
(commit: 8c2c554)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/entities/EnrollmentEntity.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/ServerKoinModule.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was removedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCaseClient.kt
The file was modifiedrespect-datalayer-db/schemas/world.respect.datalayer.db.RespectSchoolDatabase/8.json (diff)
The file was removedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/addchild/AddChildAccountUseCaseDb.kt
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/adapters/EnrollmentAdapter.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/EnrollmentDataSourceDb.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/daos/EnrollmentEntityDao.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/child/AddChildAccountUseCaseDataSource.kt
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/EnrollmentDataSourceHttp.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/profile/SignupViewModel.kt (diff)
Commit 66f6df5bd24d0c4c2dfa1b574c2eddfd59536684 by Mike Dawson
Update PersonListScreen to make it easier for the Maestro test to get the invite code.
(commit: 66f6df5)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/list/PersonListScreen.kt (diff)
Commit 079da7e476b8ed4d8bf01d23175549c97aef0ec6 by Mike Dawson
Minor tidy changes:
1) Remove personedit padding on column - each field has its own padding
2) Remove "dob" as a string - this is short, but not clear.
(commit: 079da7e)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/detail/PersonDetailScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)
Commit 67f40bec899f985f74f0ce1c10684da932654664 by Pooja Ravi
updated copy-paste - invite code
(commit: 67f40be)
The file was modified.maestro/flows/001_001_invite_using_invite_code_test.yaml (diff)
Commit e56d3cd10a7b4aadc4690e596a49ae4665f7518b by Mike Dawson
Remove class_name_label string and change admin_add_app_and_teacher to use name not class name.
(commit: e56d3cd)
The file was modified.maestro/flows/subflows/admin_add_app_and_teacher.yaml (diff)
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
Commit e8f86daad06456fc45b82b0a6908c43fa8898f0b by Mike Dawson
Fix labels on 001_001 invite test to match those currently used
Ensure edit screens have testTags on textfields.
(commit: e8f86da)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectLocalDateTimeField.kt (diff)
The file was modified.maestro/flows/001_001_invite_using_invite_code_test.yaml (diff)
The file was modified.maestro/flow-passkey/006_user_signup_using_passkey_test.yaml (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/edit/ClazzEditScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/edit/AssignmentEditScreen.kt (diff)
Commit 7f3cdea198a40d2caef24920306f2d374ba02b5d by Mike Dawson
Fix label match admin_add_app_and_teacher

Pending requests had the number of requests added to the end, so previous assertvisible failed. Users have role added in brackets.
(commit: 7f3cdea)
The file was modified.maestro/flows/subflows/admin_add_app_and_teacher.yaml (diff)
The file was modified.maestro/flow-passkey/006_user_signup_using_passkey_test.yaml (diff)
Commit ad70644ea551653e7f6a6275053f58bc9ec10143 by lipsa.behera
Fix lesson selection flow to use RouteResultDest
(commit: ad70644)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/curriculum/mapping/edit/CurriculumMappingEditViewModel.kt (diff)