primary-bottomnav-visiblitysetting Git changeshttps://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/changesprimary-bottomnav-visiblitysetting Git changes#51 test code updated (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/51/changes#detail0job/primary-bottomnav-visiblitysetting/51/changes#detail0Thu, 14 Aug 2025 11:11:34 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/support/commands.js #49 test code updated- removed maxretries (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/49/changes#detail0job/primary-bottomnav-visiblitysetting/49/changes#detail0Wed, 13 Aug 2025 16:04:50 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/support/commands.js test-end-to-end/webapp-cypress/cypress/e2e/WEB_007_007b_admin_send_group_invitation_to_join_course_via_email.cy.js #48 Fix error in AbstractAppActivity: downloads would be shown when any extra arguments were passed with the intent (even if showDownloads is not set or false). (mike)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/48/changes#detail0job/primary-bottomnav-visiblitysetting/48/changes#detail0Sun, 10 Aug 2025 18:10:27 +0400no-reply@ustadmobile.comapp-android/src/main/java/com/ustadmobile/port/android/view/AbstractAppActivity.kt #48 Update compile sdk and target sdk to 35 (Android 15) (mike)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/48/changes#detail1job/primary-bottomnav-visiblitysetting/48/changes#detail1Sun, 10 Aug 2025 18:10:27 +0400no-reply@ustadmobile.comlib-cache/build.gradle.kts lib-xxhashkmp-commonjvmimpl/build.gradle.kts app-android-baselineprofile/build.gradle.kts lib-ihttp-nanohttpd/build.gradle.kts lib-centralappconfigdb-common/build.gradle.kts lib-ihttp-okhttp/build.gradle.kts core/build.gradle lib-ui-compose/build.gradle.kts sharedse/build.gradle lib-centralappconfigdb-sqldelight/build.gradle.kts lib-xxhashkmp/build.gradle.kts build.gradle lib-database/build.gradle lib-xxhashkmp-core/build.gradle.kts lib-ihttp-core/build.gradle.kts lib-util/build.gradle lib-ihttp-iostreams/build.gradle.kts #48 removed ${TESTCOURSENAME} and added course name "Test Course Block" (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/48/changes#detail2job/primary-bottomnav-visiblitysetting/48/changes#detail2Sun, 10 Aug 2025 18:10:27 +0400no-reply@ustadmobile.comtest-end-to-end/android-maestro/e2e-tests/002_001_admin_add_new_course_and_teacher.yaml test-end-to-end/android-maestro/e2e-tests/003_005_course_view_and_modules_can_expand_collapse.yaml test-end-to-end/android-maestro/e2e-tests/004_003_multiple_submission_possible_for_student.yaml test-end-to-end/android-maestro/e2e-tests/003_006_all_user_able_to_open_text_block.yaml #48 Fix handling of using the site database within React. (mike)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/48/changes#detail3job/primary-bottomnav-visiblitysetting/48/changes#detail3Sun, 10 Aug 2025 18:10:27 +0400no-reply@ustadmobile.comapp-react/src/jsMain/kotlin/com/ustadmobile/mui/components/Sidebar.kt app-react/src/jsMain/kotlin/com/ustadmobile/mui/components/UstadRootScreenNavLinks.kt app-react/src/jsMain/kotlin/com/ustadmobile/mui/components/UstadScreens.kt #47 worked on pull request comment (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/47/changes#detail0job/primary-bottomnav-visiblitysetting/47/changes#detail0Tue, 8 Jul 2025 18:43:52 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/login/LoginViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignupEnterUsernamePasswordViewModel.kt #46 changes in login for GetDefaultDestinationUseCase (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/46/changes#detail0job/primary-bottomnav-visiblitysetting/46/changes#detail0Fri, 4 Jul 2025 15:03:31 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/site/edit/SiteEditViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/login/LoginViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/redirect/RedirectViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignupEnterUsernamePasswordViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/domain/navigation/GetDefaultDestinationUseCase.kt core/src/commonMain/kotlin/com/ustadmobile/core/util/ext/NavControllerExt.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/addaccountselectneworexisting/AddAccountSelectNewOrExistingViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/list/AccountListViewModel.kt #45 Add comment on RedirectViewModel . (mike)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/45/changes#detail0job/primary-bottomnav-visiblitysetting/45/changes#detail0Fri, 4 Jul 2025 13:57:45 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/redirect/RedirectViewModel.kt #44 testing (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/44/changes#detail0job/primary-bottomnav-visiblitysetting/44/changes#detail0Fri, 4 Jul 2025 11:02:45 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/domain/navigation/GetDefaultDestinationUseCase.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/redirect/RedirectViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/util/ext/NavControllerExt.kt #43 pull request comment fixes (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/43/changes#detail0job/primary-bottomnav-visiblitysetting/43/changes#detail0Wed, 2 Jul 2025 19:04:01 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/site/edit/SiteEditViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/login/LoginViewModel.kt app-react/src/jsMain/kotlin/com/ustadmobile/mui/components/Sidebar.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignupEnterUsernamePasswordViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/domain/navigation/GetDefaultDestinationUseCase.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt lib-ui-compose/src/commonMain/kotlin/com/ustadmobile/libuicompose/view/site/edit/SiteEditScreen.kt app-desktop/src/main/java/com/ustadmobile/port/desktop/App.kt app-react/src/jsMain/kotlin/com/ustadmobile/view/site/edit/SiteEditScreen.kt #41 import issue (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/41/changes#detail0job/primary-bottomnav-visiblitysetting/41/changes#detail0Mon, 30 Jun 2025 09:16:00 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt #40 fixes for the issues (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/40/changes#detail0job/primary-bottomnav-visiblitysetting/40/changes#detail0Fri, 27 Jun 2025 16:19:05 +0400no-reply@ustadmobile.comcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/GetCredentialUseCaseImpl.kt core/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/GetCredentialUseCase.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/person/manageaccount/ManageAccountViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/login/LoginViewModel.kt lib-ui-compose/src/commonMain/kotlin/com/ustadmobile/libuicompose/view/signup/OtherSignUpOptionSelectionScreen.kt core/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyUseCase.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/OtherSignUpOptionSelectionViewModel.kt core/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/addaccountselectneworexisting/AddAccountSelectNewOrExistingViewModel.kt #40 code cleanup (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/40/changes#detail1job/primary-bottomnav-visiblitysetting/40/changes#detail1Fri, 27 Jun 2025 16:19:05 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/person/manageaccount/ManageAccountViewModel.kt app-react/src/jsMain/kotlin/com/ustadmobile/view/person/manageaccount/ManageAccountScreen.kt lib-ui-compose/src/commonMain/kotlin/com/ustadmobile/libuicompose/view/person/manageaccount/ManageAccountScreen.kt core/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyUseCase.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/OtherSignUpOptionSelectionViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt core/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/addaccountselectneworexisting/AddAccountSelectNewOrExistingViewModel.kt #40 clean up (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/40/changes#detail2job/primary-bottomnav-visiblitysetting/40/changes#detail2Fri, 27 Jun 2025 16:19:05 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/login/LoginViewModel.kt #40 Minor space tidyup and variable renaming. (mike)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/40/changes#detail3job/primary-bottomnav-visiblitysetting/40/changes#detail3Fri, 27 Jun 2025 16:19:05 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/person/manageaccount/ManageAccountViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/OtherSignUpOptionSelectionViewModel.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt core/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt #39 maestro test flow and description updated (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/39/changes#detail0job/primary-bottomnav-visiblitysetting/39/changes#detail0Thu, 26 Jun 2025 19:26:01 +0400no-reply@ustadmobile.comtest-end-to-end/test-descriptions/007_001_admin_enable_or_disable_user_registration_and_manage_bottom_navigation_bar_test_description.md test-end-to-end/android-maestro/e2e-tests/007_001_admin_enable_or_disable_user_registration_and_manage_bottom_navigation_bar.yaml test-end-to-end/test-descriptions/007_001_admin_enable_or_disable_user_registration_test_description.md #38 cypress test flow updated (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/38/changes#detail0job/primary-bottomnav-visiblitysetting/38/changes#detail0Thu, 26 Jun 2025 18:20:20 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/e2e/WEB_007_001_admin_enable_or_disable_user_registration_and_manage_bottom_navigation_bar.cy.js #36 added fieldsEnabled in AddAccountSelectNewOrExistingScreen (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/36/changes#detail0job/primary-bottomnav-visiblitysetting/36/changes#detail0Thu, 26 Jun 2025 16:22:07 +0400no-reply@ustadmobile.comapp-react/src/jsMain/kotlin/com/ustadmobile/view/person/addaccount/AddAccountSelectNewOrExistingScreen.kt core/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/addaccountselectneworexisting/AddAccountSelectNewOrExistingViewModel.kt #35 issue fixed (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/35/changes#detail0job/primary-bottomnav-visiblitysetting/35/changes#detail0Thu, 26 Jun 2025 16:12:20 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/site/edit/SiteEditViewModel.kt #34 error message showing now if registration allowed without adding terms (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail0job/primary-bottomnav-visiblitysetting/34/changes#detail0Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comapp-react/src/jsMain/kotlin/com/ustadmobile/view/site/edit/SiteEditScreen.kt #34 e2e_cypress test (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail1job/primary-bottomnav-visiblitysetting/34/changes#detail1Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/support/commands.js #34 test update - cypress (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail2job/primary-bottomnav-visiblitysetting/34/changes#detail2Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/support/commands.js #34 test update - maestro (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail3job/primary-bottomnav-visiblitysetting/34/changes#detail3Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/support/commands.js test-end-to-end/android-maestro/e2e-tests/common/enable_user_registration.yaml #34 when registration allowed toggle is off then error message was till showing so that is fixed in this commit (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail4job/primary-bottomnav-visiblitysetting/34/changes#detail4Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/site/edit/SiteEditViewModel.kt #34 Modified test flow on cypress (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail5job/primary-bottomnav-visiblitysetting/34/changes#detail5Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/support/commands.js test-end-to-end/webapp-cypress/cypress/e2e/WEB_007_001_admin_enable_or_disable_user_registration.cy.js #34 Modified test description (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail6job/primary-bottomnav-visiblitysetting/34/changes#detail6Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comtest-end-to-end/test-descriptions/007_001_admin_enable_or_disable_user_registration_test_description.md #34 Modified maestro test (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail7job/primary-bottomnav-visiblitysetting/34/changes#detail7Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comtest-end-to-end/android-maestro/e2e-tests/common/enable_user_registration.yaml test-end-to-end/android-maestro/e2e-tests/007_001_admin_enable_or_disable_user_registration.yaml #34 test update - cypress - added wait to give time to load the switch (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail8job/primary-bottomnav-visiblitysetting/34/changes#detail8Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/support/commands.js test-end-to-end/webapp-cypress/cypress/e2e/WEB_007_001_admin_enable_or_disable_user_registration.cy.js #34 #comment time to load the switch (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail9job/primary-bottomnav-visiblitysetting/34/changes#detail9Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/e2e/WEB_007_001_admin_enable_or_disable_user_registration.cy.js #34 removed wait and force:true from cypress test (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail10job/primary-bottomnav-visiblitysetting/34/changes#detail10Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/support/commands.js test-end-to-end/webapp-cypress/cypress/e2e/WEB_007_001_admin_enable_or_disable_user_registration.cy.js #34 updated SiteEditScreen (nikunj.sharma)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail11job/primary-bottomnav-visiblitysetting/34/changes#detail11Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comapp-react/src/jsMain/kotlin/com/ustadmobile/view/site/edit/SiteEditScreen.kt #34 Update Android Gradle Plugin version to 8.11.0 (mike)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/34/changes#detail12job/primary-bottomnav-visiblitysetting/34/changes#detail12Thu, 26 Jun 2025 12:40:04 +0400no-reply@ustadmobile.comgradle/wrapper/gradle-wrapper.properties build.gradle #33 test update-007_006 (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/33/changes#detail0job/primary-bottomnav-visiblitysetting/33/changes#detail0Thu, 26 Jun 2025 09:47:29 +0400no-reply@ustadmobile.comtest-end-to-end/android-maestro/e2e-tests/007_006_admin_enable_or_disable_guest_login.yaml #32 test updated as per latest design 25/06 (pooja)https://devserver3.ustadmobile.com/jenkins/job/primary-bottomnav-visiblitysetting/32/changes#detail0job/primary-bottomnav-visiblitysetting/32/changes#detail0Wed, 25 Jun 2025 16:22:44 +0400no-reply@ustadmobile.comtest-end-to-end/webapp-cypress/cypress/support/commands.js test-end-to-end/webapp-cypress/cypress/e2e/WEB_007_001_admin_enable_or_disable_user_registration_and_manage_bottom_navigation_bar.cy.js test-end-to-end/android-maestro/e2e-tests/007_001_admin_enable_or_disable_user_registration_and_manage_bottom_navigation_bar.yaml