Started by timer

48129ac91e8fef8241b6904a66183ea6ab8067e7be129ac91e8fef8241b6904a66183ea6ab8067e7berefs/remotes/origin/dev-student-grouping129ac91e8fef8241b6904a66183ea6ab8067e7be129ac91e8fef8241b6904a66183ea6ab8067e7berefs/remotes/origin/dev-student-grouping

129ac91e8fef8241b6904a66183ea6ab8067e7be129ac91e8fef8241b6904a66183ea6ab8067e7berefs/remotes/origin/dev-student-groupinghttps://github.com/UstadMobile/Respect.gitrespect-app-compose-debug.apkrespect-app-compose-debug.apkrespect-app-compose/build/outputs/apk/debug/respect-app-compose-debug.apkrespect-app-compose-release.apkrespect-app-compose-release.apkrespect-app-compose/build/outputs/apk/release/respect-app-compose-release.apkrespect-app-compose-debug.aabrespect-app-compose-debug.aabrespect-app-compose/build/outputs/bundle/debug/respect-app-compose-debug.aabrespect-app-compose-release.aabrespect-app-compose-release.aabrespect-app-compose/build/outputs/bundle/release/respect-app-compose-release.aabmapping.txtmapping.txtrespect-app-compose/build/outputs/mapping/release/mapping.txtrespect-cli.ziprespect-cli.ziprespect-cli/build/distributions/respect-cli.ziprespect-server-1.0.0.ziprespect-server-1.0.0.ziprespect-server/build/distributions/respect-server-1.0.0.ziprespect-server-shadow-1.0.0.ziprespect-server-shadow-1.0.0.ziprespect-server/build/distributions/respect-server-shadow-1.0.0.zipfalse#48204747184107dev-student-grouping #4848falsefalse488588SUCCESS1779335040994https://devserver3.ustadmobile.com/jenkins/view/all/job/dev-student-grouping/48/CODING_GUIDELINES.md07731c383a17fb4a0b24db0e760868b6e3acd65d1779185716000https://devserver3.ustadmobile.com/jenkins/user/noreplynoreplynoreply@github.comAdd guideline on understanding code before committing Added guideline about understanding and explaining code before committing. 2026-05-19 14:15:16 +040007731c383a17fb4a0b24db0e760868b6e3acd65dAdd guideline on understanding code before committingeditCODING_GUIDELINES.mdCODING_GUIDELINES.md18b1fed572b7f8d297d29d9835b62ce9433d97f71779186074000https://devserver3.ustadmobile.com/jenkins/user/noreplynoreplynoreply@github.comClarify variable usage in coding guidelines Added guideline to avoid using two variables for the same purpose. 2026-05-19 14:21:14 +040018b1fed572b7f8d297d29d9835b62ce9433d97f7Clarify variable usage in coding guidelineseditCODING_GUIDELINES.mdrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/studentgrouping/edit/StudentGroupingEditScreen.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiStatementExt.kta93d8f58578f169f9b72317be29708607c910dcf1779188387000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgIntroduce `XapiStatementExt.kt` to centralize xAPI helper functions and refactor student grouping ViewModels. 2026-05-19 16:29:47 +0530a93d8f58578f169f9b72317be29708607c910dcfIntroduce `XapiStatementExt.kt` to centralize xAPI helper functions and refactor student grouping ViewModels.editrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/studentgrouping/edit/StudentGroupingEditScreen.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.ktaddrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiStatementExt.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiStatementExt.kta47996dd06f5d2dcd1a6235ca362a94347fdaf011779189193000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgRemove unused `SchoolDataSource` import in `XapiStatementExt.kt`. 2026-05-19 16:43:13 +0530a47996dd06f5d2dcd1a6235ca362a94347fdaf01Remove unused `SchoolDataSource` import in `XapiStatementExt.kt`.editrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiStatementExt.ktAGENTS.md5faf3ac280de655c20c419f87c90a788297e04881779190932000https://devserver3.ustadmobile.com/jenkins/user/mikeMike Dawsonmike@ustadmobile.comUpdate AGENTS.md to refer to CODING_GUIDELINES.md 2026-05-19 15:42:12 +04005faf3ac280de655c20c419f87c90a788297e0488Update AGENTS.md to refer to CODING_GUIDELINES.mdeditAGENTS.mdrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/composites/XapiAssignmentProgress.ktrespect-datalayer-repository/src/commonMain/kotlin/world/respect/datalayer/repository/school/xapi/XapiStatementsResourceRepository.ktrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiStatementExt.ktrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.ktrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/xapi/XapiStatementsResourceHttp.ktrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/composites/XapiAssignmentResultRow.ktrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/composites/XapiActorAndAssignmentProgress.ktrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/resources/XapiStatementsResource.ktrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/adapters/XapiAssignmentResultRowAdapter.ktrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.ktrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiConstants.ktde2604a5d24886f12e1eb367420d2fadfc323bea1779264668000https://devserver3.ustadmobile.com/jenkins/user/mikeMike Dawsonmike@ustadmobile.comImplement initial version of getAssignmentProgress 2026-05-20 12:11:08 +0400de2604a5d24886f12e1eb367420d2fadfc323beaImplement initial version of getAssignmentProgressaddrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/composites/XapiAssignmentProgress.kteditrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiStatementExt.kteditrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kteditrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/resources/XapiStatementsResource.kteditrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/xapi/XapiStatementsResourceHttp.ktaddrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/composites/XapiAssignmentResultRow.ktaddrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/adapters/XapiAssignmentResultRowAdapter.kteditrespect-datalayer-repository/src/commonMain/kotlin/world/respect/datalayer/repository/school/xapi/XapiStatementsResourceRepository.kteditrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.ktaddrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiConstants.ktaddrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/composites/XapiActorAndAssignmentProgress.ktrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/xapi/getxapilaunchurl/GetXapiLaunchUrlUseCaseAndroid.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/RespectSessionAndPerson.kt5f10957c07e8780e0f37aa70d3caf1d0d0b707ea1779268277000https://devserver3.ustadmobile.com/jenkins/user/mikeMike Dawsonmike@ustadmobile.comAdd xapiAgent property to RespectSessionAndPerson 2026-05-20 13:11:17 +04005f10957c07e8780e0f37aa70d3caf1d0d0b707eaAdd xapiAgent property to RespectSessionAndPersoneditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/RespectSessionAndPerson.kteditrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/xapi/getxapilaunchurl/GetXapiLaunchUrlUseCaseAndroid.ktrespect-lib-shared/build.gradle.ktsrespect-app-compose/build.gradle.kts7827d2b6a33d40da5aa71e650b7829df332a58d01779269222000https://devserver3.ustadmobile.com/jenkins/user/mikeMike Dawsonmike@ustadmobile.comAdd Uuid opt-in to respect-app-compose and respect-lib-shared. 2026-05-20 13:27:02 +04007827d2b6a33d40da5aa71e650b7829df332a58d0Add Uuid opt-in to respect-app-compose and respect-lib-shared.editrespect-app-compose/build.gradle.ktseditrespect-lib-shared/build.gradle.ktsrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/studentgrouping/edit/StudentGroupingEditScreen.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.ktfd555e517d67bb2433e8ab75b059c60ba5b8cf771779269505000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgRemove unused `SchoolDataSource` import in `XapiStatementExt.kt`. 2026-05-20 15:01:45 +0530fd555e517d67bb2433e8ab75b059c60ba5b8cf77Remove unused `SchoolDataSource` import in `XapiStatementExt.kt`.editrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/studentgrouping/edit/StudentGroupingEditScreen.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/ClazzExt.kt7a93561a33094be6b42cea2d81d6731ef31335a41779270302000https://devserver3.ustadmobile.com/jenkins/user/mikeMike Dawsonmike@ustadmobile.comAdd studentsXapiGroup function 2026-05-20 13:45:02 +04007a93561a33094be6b42cea2d81d6731ef31335a4Add studentsXapiGroup functionaddrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/ClazzExt.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kte686becd21c74ffff565a458fe7d198a258e71e81779270546000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgUpdate group filtering logic in `ClazzDetailViewModel.kt` to handle null timestamps and ensure distinct groups are correctly mapped from xAPI statements. 2026-05-20 15:19:06 +0530e686becd21c74ffff565a458fe7d198a258e71e8Update group filtering logic in `ClazzDetailViewModel.kt` to handle null timestamps and ensure distinct groups are correctly mapped from xAPI statements.editrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiStatementExt.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.ktebd422f539efa51cb39987b2eb0cc9b11acce0391779277742000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgRemove `XapiStatementExt.kt` and inline xAPI agent and statement creation logic within `StudentGroupingDetailViewModel` and `StudentGroupingEditViewModel`. Use `xapiAgent` directly from the selected account session and manually construct `XapiStatement` and `XapiAgent` objects for group management and voiding operations. 2026-05-20 17:19:02 +0530ebd422f539efa51cb39987b2eb0cc9b11acce039Remove `XapiStatementExt.kt` and inline xAPI agent and statement creation logic within `StudentGroupingDetailViewModel` and `StudentGroupingEditViewModel`. Use `xapiAgent` directly from the selected account session and manually construct `XapiStatement` and `XapiAgent` objects for group management and voiding operations.deleterespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiStatementExt.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.ktb3324ae44944ea82456668a43d5eca3c858bd1b21779278331000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgRemove unnecessary empty lines in `ClazzDetailViewModel.kt`. 2026-05-20 17:28:51 +0530b3324ae44944ea82456668a43d5eca3c858bd1b2Remove unnecessary empty lines in `ClazzDetailViewModel.kt`.editrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.ktb8a2ca238c859dfde5d3b59a90a47617b74eeb031779279235000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgApply minor formatting and whitespace adjustments to `ClazzDetailViewModel.kt`. 2026-05-20 17:43:55 +0530b8a2ca238c859dfde5d3b59a90a47617b74eeb03Apply minor formatting and whitespace adjustments to `ClazzDetailViewModel.kt`.editrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.ktrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/xapi/XapiActorDataSource.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.ktrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/studentgrouping/edit/StudentGroupingEditScreen.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.ktrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt129ac91e8fef8241b6904a66183ea6ab8067e7be1779293146000https://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.vermamandvi.verma@sutara.orgImprove error handling and data robustness in student grouping view models and screens. - Add `Napier` logging and replace potential crashes with safe checks and early returns in `StudentGroupingDetailViewModel`, `ClazzDetailViewModel`, and `StudentGroupingEditViewModel`. - Refactor `StudentGroupingEditState` to calculate `selectedStudentIds` dynamically from the student list. - Enhance group filtering and mapping logic in `ClazzDetailViewModel` to handle missing group/member data gracefully. - Update UI components in `StudentGroupingEditScreen` and `ClazzDetailScreen` to safely handle null items and improve key mapping. - Delete unused `XapiActorDataSource.kt`. 2026-05-20 21:35:46 +0530129ac91e8fef8241b6904a66183ea6ab8067e7beImprove error handling and data robustness in student grouping view models and screens.editrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kteditrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/studentgrouping/edit/StudentGroupingEditScreen.ktdeleterespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/xapi/XapiActorDataSource.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.kteditrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.ktgithttps://devserver3.ustadmobile.com/jenkins/user/noreplynoreplyhttps://devserver3.ustadmobile.com/jenkins/user/mikeMike Dawsonhttps://devserver3.ustadmobile.com/jenkins/user/mandvi.vermamandvi.verma