Skip to content

Changes

Started by Pooja Ravi
Started 17 days ago
Took 1 min 25 sec

Summary

  1. Configuration loading for Zammad credentials has been updated in `build.gradle.kts`, now sourcing the token and URL from a `zammad.properties` file or environment variables. (details)
  2. refactor: Integrate FeedbackDataSource into SchoolDataSource (details)
  3. Handle feedback submission errors and hide navigation (details)
  4. Refactor: Append "UseCase" to launcher class names (details)
  5. Removes the `FeedBackDataSource`, its HTTP implementation, and repository, along with their integration into the existing data source layers. The responsibility for feedback ticket creation has been moved from the data layer to the `ShareFeedbackViewModel`. (details)
  6. feat: Refactored feedback property names for clarity and consistency. (details)
  7. Update build.gradle.kts (details)
  8. Update AppKoinModule.kt (details)
  9. feat: Integrate Zammad for feedback submission and refactor configuration (details)
  10. feat: Display Zammad ticket ID on feedback submission screen (details)
  11. removed feedback changes from 003 (details)
Commit b2537e62509dfa2cedcb0b938e04431a70b8f72e by mandvi.verma
Configuration loading for Zammad credentials has been updated in `build.gradle.kts`, now sourcing the token and URL from a `zammad.properties` file or environment variables.
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was modifiedrespect-app-compose/build.gradle.kts (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/sharefeedback/ShareFeedbackViewModel.kt (diff)
Commit 76cd48a5efd336dc8c549ff95dde093f553d7dcc by mandvi.verma
refactor: Integrate FeedbackDataSource into SchoolDataSource

Extracted the `FeedBackDataSource` into the `SchoolDataSource` interface and its various implementations (`Http`, `Db`, `Repository`). This refactoring centralizes data source access.

Key changes include:
- Passing Zammad URL and token configurations from the `AppKoinModule` to `SchoolDataSourceHttp`.
- Updating `ShareFeedbackViewModel` to obtain the `feedBackDataSource` via the main `SchoolDataSource`.
- Removing the hardcoded Zammad URL from `FeedbackDataSourceHttp` and using the configured one instead.
- Hiding the bottom navigation on the "Share Feedback" screen.
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/SchoolDataSourceDb.kt (diff)
The file was modifiedrespect-datalayer-repository/src/commonMain/kotlin/world/respect/datalayer/repository/SchoolDataSourceRepository.kt (diff)
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/sharefeedback/FeedbackDataSourceHttp.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/sharefeedback/ShareFeedbackViewModel.kt (diff)
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/SchoolDataSourceHttp.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/SchoolDataSource.kt (diff)
Commit aeea06f22157081cdd4b39d9b45681bc3482b0f4 by mandvi.verma
Handle feedback submission errors and hide navigation

- Checks the HTTP response status after attempting to create a feedback ticket.
- Displays a generic error message to the user if the ticket submission fails.
- On the feedback submission confirmation screen, the bottom navigation is now hidden.
- The `createTicket` function in the data source and view model now returns an `HttpResponse` to enable status checking.
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/sharefeedback/FeedbackSubmittedViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/sharefeedback/ShareFeedbackViewModel.kt (diff)
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/sharefeedback/FeedbackDataSourceHttp.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/sharefeedback/FeedBackDataSource.kt (diff)
Commit 741ff12b56f782bf6fa602ae19402ce5b24b026d by mandvi.verma
Refactor: Append "UseCase" to launcher class names

Renamed the `EmailLauncher`, `WebLauncher`, and `WhatsAppLauncher` classes and their corresponding Android implementations to `EmailLauncherUseCase`, `WebLauncherUseCase`, and `WhatsAppLauncherUseCase` respectively. This change makes their purpose as use cases clearer and aligns them with the project's naming conventions.

The `ShareFeedbackViewModel` and the Koin dependency injection module have been updated to reflect these new class names.
The file was removedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchers/WebLauncher.kt
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchers/WhatsAppLauncherUseCase.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/sharefeedback/ShareFeedbackViewModel.kt (diff)
The file was removedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchers/WhatsAppLauncher.kt
The file was removedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchers/EmailLauncherAndroid.kt
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchers/EmailLauncherUseCase.kt
The file was addedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchers/WhatsAppLauncherUseCaseAndroid.kt
The file was removedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchers/EmailLauncher.kt
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was removedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchers/WhatsAppLauncherAndroid.kt
The file was addedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchers/EmailLauncherUseCaseAndroid.kt
The file was removedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchers/WebLauncherAndroid.kt
The file was addedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchers/WebLauncherUseCaseAndroid.kt
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchers/WebLauncherUseCase.kt
Commit f4de51a39e15ee38525f4984521f1ff869953108 by mandvi.verma
Removes the `FeedBackDataSource`, its HTTP implementation, and repository, along with their integration into the existing data source layers. The responsibility for feedback ticket creation has been moved from the data layer to the `ShareFeedbackViewModel`.

Additionally, Zammad API credentials (URL and token) are now configured through `buildConfigField` in the `respect-lib-shared` module, removing the previous hardcoded values and `respect-app-compose` build configurations.
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was removedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/sharefeedback/FeedbackDataSourceHttp.kt
The file was modifiedrespect-lib-shared/build.gradle.kts (diff)
The file was modifiedrespect-datalayer-repository/src/commonMain/kotlin/world/respect/datalayer/repository/SchoolDataSourceRepository.kt (diff)
The file was removedrespect-datalayer-repository/src/commonMain/kotlin/world/respect/datalayer/repository/sharefeedback/FeedBackDataSourceRepository.kt
The file was removedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/sharefeedback/FeedBackDataSource.kt
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/SchoolDataSourceHttp.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/SchoolDataSourceDb.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/SchoolDataSource.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/sharefeedback/ShareFeedbackViewModel.kt (diff)
The file was modifiedrespect-app-compose/build.gradle.kts (diff)
Commit d40c7cc0b87c46fff6d4993e6bd088461452db09 by mandvi.verma
feat: Refactored feedback property names for clarity and consistency.

Renamed Zammad and Respect contact properties to use a `FEEDBACK_` prefix, improving clarity about their purpose. This change affects build configuration files (`build.gradle.kts`) by renaming build config fields and the property files from which they are loaded (e.g., `zammad.properties` to `feedback.properties`).

Specifically, the following properties were renamed:
- `ZAMMAD_URL` to `FEEDBACK_ZAMMADURL`
- `ZAMMAD_TOKEN` to `FEEDBACK_ZAMMADTOKEN`

Additionally, new properties for Respect's contact details were introduced with the same naming convention:
- `FEEDBACK_RESPECTPHONENUMBER`
- `FEEDBACK_RESPECTEMAILID`
The file was modifiedrespect-app-compose/build.gradle.kts (diff)
The file was modifiedrespect-lib-shared/build.gradle.kts (diff)
Commit 6d249989f5de189a7a2a9efda5faa9581d947a09 by noreply
Update build.gradle.kts
The file was modifiedrespect-lib-shared/build.gradle.kts (diff)
Commit 6114a11cce90d520c07570b8502128178db91c0d by noreply
Update AppKoinModule.kt
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
Commit a3eef313e4a16ce1ae3718a622c9691e3c799ecf by mandvi.verma
feat: Integrate Zammad for feedback submission and refactor configuration

Integrated the feedback submission feature with the Zammad ticketing system. When a user submits feedback, a ticket is now created in Zammad, and the resulting ticket ID is passed to the confirmation screen.

Key changes include:
- A new `CreateTicketUseCase` is introduced to handle the API call to Zammad.
- The `ShareFeedbackViewModel` now uses this use case to create a ticket and navigates to a success screen with the new ticket ID.
- Configuration properties for Zammad (URL, token) and contact details (phone, email) have been moved from the `respect-app-compose` module to the `respect-lib-shared` module. This centralizes feedback-related settings.
- The `EmailLauncherUseCase` and `WhatsAppLauncherUseCase` were updated to use the newly centralized contact information.
The file was modifiedrespect-app-compose/build.gradle.kts (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/sharefeedback/ShareFeedbackViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchers/EmailLauncherUseCase.kt (diff)
The file was modifiedrespect-lib-shared/build.gradle.kts (diff)
The file was modifiedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchers/EmailLauncherUseCaseAndroid.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchers/WhatsAppLauncherUseCase.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/AppRoutes.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/sharefeedback/FeedbackSubmittedScreen.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/feedback/FeedbackTicket.kt
The file was addedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/feedback/CreateTicketUseCaseImpl.kt
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/feedback/CreateTicketUseCase.kt
The file was removedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/sharefeedback/model/FeedbackTicket.kt
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/feedback/ZammadTicketResponse.kt
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/feedback/GetFeedbackInfoUseCase.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/sharefeedback/FeedbackSubmittedViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was modifiedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchers/WhatsAppLauncherUseCaseAndroid.kt (diff)
The file was addedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/feedback/GetFeedbackInfoUseCaseImpl.kt
Commit ebdf205e7743ca2e21c120d1984761739dd04ca5 by mandvi.verma
feat: Display Zammad ticket ID on feedback submission screen

Adds the Zammad ticket ID to the "Feedback Submitted" screen, making it visible to the user for reference. This ID is displayed in a new `Text` element and tagged for testing purposes.
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/sharefeedback/FeedbackSubmittedScreen.kt (diff)
Commit a2cb2fbb73001a7b5f887356164076ff6e989a18 by Pooja Ravi
removed feedback changes from 003
The file was modified.maestro/flows/003_admin_user_assigns_assignment_to_a_class_test.yaml (diff)