Skip to content
Sign in

Changes

Started by Pooja Ravi
Started 13 hr ago
Took 11 min

Summary

  1. Add xapiAgent property to RespectSessionAndPerson (details)
  2. Add Uuid opt-in to respect-app-compose and respect-lib-shared. (details)
  3. Add studentsXapiGroup function (details)
  4. Fix XapiStatementEntityDao (details)
  5. Fix XapiStatementEntityDao (details)
  6. Fix XapiActorExt.distinctMerged function (details)
  7. Fix mistake on XapiStatementEntityDao get assignment progress function: incorrect use of group. (details)
  8. Make assignment progress query test more rigorous. (details)
  9. Implement creation of an XapiGroup for students in a given class to enable assignments to work as expected. (details)
  10. refactor (details)
  11. Remove the app url argument from Learning Unit Detail screen. This should not be required. (details)
  12. Add publication extension readme. (details)
  13. fix assignment detail viewmodel (details)
  14. refactor (details)
  15. remove  hardcoded English string literals (details)
  16. refactor (details)
Commit 5f10957c07e8780e0f37aa70d3caf1d0d0b707ea by Mike Dawson
Add xapiAgent property to RespectSessionAndPerson
The file was modifiedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/xapi/getxapilaunchurl/GetXapiLaunchUrlUseCaseAndroid.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/RespectSessionAndPerson.kt (diff)
Commit 7827d2b6a33d40da5aa71e650b7829df332a58d0 by Mike Dawson
Add Uuid opt-in to respect-app-compose and respect-lib-shared.
The file was modifiedrespect-app-compose/build.gradle.kts (diff)
The file was modifiedrespect-lib-shared/build.gradle.kts (diff)
Commit 7a93561a33094be6b42cea2d81d6731ef31335a4 by Mike Dawson
Add studentsXapiGroup function
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/ClazzExt.kt
Commit 81f315480906410a35e706d6b9102c1e64076aaa by Mike Dawson
Fix XapiStatementEntityDao

The Xapi search query used Join XapiVerbEntity instead of left join. The XapiVerbEntity is only created when a verb has display properties.

This broke the query such that statements that used verbs that had no display properties would not be returned.
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
Commit 2e51e61093b64abdb3ce834e8f8166cc86dc2eca by Mike Dawson
Fix XapiStatementEntityDao

The Xapi search query used Join XapiVerbEntity instead of left join. The XapiVerbEntity is only created when a verb has display properties.

This broke the query such that statements that used verbs that had no display properties would not be returned.
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/composites/XapiStatementAndJsonEntities.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/entities/XapiVerbEntity.kt (diff)
Commit 39869b40a763fc14c8e02094fe373e2b93accd8c by Mike Dawson
Fix XapiActorExt.distinctMerged function

DistinctMerged function was not handling identified groups correctly: the returned group member was not null even if it was null in the input. This caused the ActorDataSource to incorrectly remove all group members.
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/xapi/ext/XapiActorExt.kt (diff)
Commit 04eeca8a1ead36288a2a1371e6a859324e142699 by Mike Dawson
Fix mistake on XapiStatementEntityDao get assignment progress function: incorrect use of group.
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/model/XapiVerb.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
Commit b0a5249bb832437f50727267f631375474f1f233 by Mike Dawson
Make assignment progress query test more rigorous.
The file was modifiedrespect-datalayer-db/src/jvmTest/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDbTest.kt (diff)
Commit 7f5e45c59ec11eb38383a9d4c8e1b9ec84c576d6 by Mike Dawson
Implement creation of an XapiGroup for students in a given class to enable assignments to work as expected.
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/invite/ApproveOrDeclineInviteRequestUseCase.kt (diff)
The file was modifiedrespect-datalayer-db/src/jvmTest/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDbTest.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/ext/PersonExt.kt (diff)
The file was modifiedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/invite/RedeemInviteUseCaseDb.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/enrollments/UpdateClazzStudentXapiGroupUseCase.kt
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/model/XapiVerb.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiActorDataSourceDb.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/ClazzExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/RespectAccountManager.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/ServerKoinModule.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiAssignmentProgressExt.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/enrollments/UpdateClazzStudentXapiGroupUseCase.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/detail/AssignmentDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiAssignmentExt.kt (diff)
Commit 5dfc66f1f8e4d4a53f4fab55d95ac9b67aab7768 by Mike Dawson
Remove the app url argument from Learning Unit Detail screen. This should not be required.
The file was addedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/opds/ext/OpdsPublicationExt.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/detail/LearningUnitDetailViewModel.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/adapters/AssignmentAdapter.kt (diff)
The file was modifiedrespect-lib-xapi-core/README_ASSIGNMENT_RECIPE.md (diff)
The file was modifiedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchapp/LaunchAppUseCaseAndroid.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/opds/ext/ReadiumLinkExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchapp/LaunchAppUseCase.kt (diff)
The file was modifiedrespect-lib-opds-model/src/commonMain/kotlin/world/respect/lib/opds/model/OpdsPublicationExt.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/model/AssignmentLearningUnitRef.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/opds/ext/OpdsFeedExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/AppRoutes.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/list/LearningUnitListViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/detail/AppsDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/learningunit/detail/LearningUnitDetailScreen.kt (diff)
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/opds/OpdsPublicationDataSourceHttp.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/LearningUnitSelection.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/edit/AssignmentEditViewModel.kt (diff)
Commit 138cb4671512350242d56a31048a7ff773c3bff0 by Mike Dawson
Add publication extension readme.
The file was addedrespect-lib-xapi-core/README_EXTENSION_PUBLICATION.md
Commit 89c05a10ee3a1f4974a422d2a589b4bdb25fafaa by Anugraha
fix assignment detail viewmodel
The file was removedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/adapters/AssignmentAdapter.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/detail/AssignmentDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiAssignmentExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/detail/AssignmentDetailScreen.kt (diff)
Commit e5d2e3cc3457e37f87592552c008fb34494514b7 by Anugraha
remove  hardcoded English string literals
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/detail/AssignmentDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiAssignmentExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/AssignmentStatusFilter.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/detail/AssignmentDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)