Skip to content
Sign in

Changes

Started by Pooja Ravi
Started 1 hr 45 min ago
Took 25 min

Summary

  1. Add guideline on understanding code before committing (details)
  2. Clarify variable usage in coding guidelines (details)
  3. Update AGENTS.md to refer to CODING_GUIDELINES.md (details)
  4. clean up AssignmentDetail,Edit screens and viewmodels (details)
  5. Remove role selection from admin add teacher subflow. (details)
  6. remove getAssignmentSummaries function (details)
  7. Implement initial version of getAssignmentProgress (details)
  8. refactor (details)
  9. resolve conflicts (details)
  10. Update Maestro flows for assignment and class management to use dynamic class names. (details)
  11. Update Maestro flows to reduce the number of students in the assignment test class. (details)
Commit 07731c383a17fb4a0b24db0e760868b6e3acd65d by noreply
Add guideline on understanding code before committing

Added guideline about understanding and explaining code before committing.
The file was modifiedCODING_GUIDELINES.md (diff)
Commit 18b1fed572b7f8d297d29d9835b62ce9433d97f7 by noreply
Clarify variable usage in coding guidelines

Added guideline to avoid using two variables for the same purpose.
The file was modifiedCODING_GUIDELINES.md (diff)
Commit 5faf3ac280de655c20c419f87c90a788297e0488 by Mike Dawson
Update AGENTS.md to refer to CODING_GUIDELINES.md
The file was modifiedAGENTS.md (diff)
Commit ab0b104794b6ed600926a6401b05c2145eaf589b by Anugraha
clean up AssignmentDetail,Edit screens and viewmodels
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/edit/AssignmentEditViewModel.kt (diff)
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/AssignmentResultExt.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/list/AssignmentListViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/detail/AssignmentDetailScreen.kt (diff)
Commit d35ef225c00a65c9e306ed535860bf32d6ee3f62 by Pooja Ravi
Remove role selection from admin add teacher subflow.
The file was modified.maestro/flows/subflows/admin_add_new_teacher_to_class.yaml (diff)
Commit 38a8e9c183bc703790887dd24b24959f923d2a4f by Anugraha
remove getAssignmentSummaries function
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
The file was removedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/model/XapiAssignmentConstants.kt
The file was modifiedrespect-datalayer-repository/src/commonMain/kotlin/world/respect/datalayer/repository/school/xapi/XapiStatementsResourceRepository.kt (diff)
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/xapi/XapiStatementsResourceHttp.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/list/AssignmentListViewModel.kt (diff)
The file was removedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/entities/XapiAssignmentSummaryEntityRow.kt
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/resources/XapiStatementsResource.kt (diff)
Commit de2604a5d24886f12e1eb367420d2fadfc323bea by Mike Dawson
Implement initial version of getAssignmentProgress
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiConstants.kt
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/composites/XapiAssignmentProgress.kt
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/composites/XapiActorAndAssignmentProgress.kt
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiStatementExt.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
The file was addedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/adapters/XapiAssignmentResultRowAdapter.kt
The file was modifiedrespect-datalayer-repository/src/commonMain/kotlin/world/respect/datalayer/repository/school/xapi/XapiStatementsResourceRepository.kt (diff)
The file was addedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/composites/XapiAssignmentResultRow.kt
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/xapi/XapiStatementsResourceHttp.kt (diff)
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/resources/XapiStatementsResource.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/list/AssignmentListViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/detail/AssignmentDetailScreen.kt (diff)
Commit 1a17fd5a6a683ac4c5b407663b9723ae30310b44 by Pooja Ravi
Update Maestro flows for assignment and class management to use dynamic class names.
The file was modified.maestro/flows/subflows/admin_add_new_student_to_class.yaml (diff)
The file was modified.maestro/flows/003_admin_user_assigns_assignment_to_a_class_test.yaml (diff)
The file was modified.maestro/flows/subflows/admin_add_new_teacher_to_class.yaml (diff)
The file was modified.maestro/flows/subflows/admin_add_class_with_members.yaml (diff)
Commit 4b36db7f8770355257894aa742542f8159510751 by Pooja Ravi
Update Maestro flows to reduce the number of students in the assignment test class.
The file was modified.maestro/flows/subflows/admin_add_class_with_members.yaml (diff)
The file was modified.maestro/flows/003_admin_user_assigns_assignment_to_a_class_test.yaml (diff)