Skip to content

Changes

Started by timer
Started 1 hr 40 min ago
Took 3 min 9 sec

Summary

  1. Add guideline on understanding code before committing (commit: 07731c3) (details)
  2. Clarify variable usage in coding guidelines (commit: 18b1fed) (details)
  3. Update AGENTS.md to refer to CODING_GUIDELINES.md (commit: 5faf3ac) (details)
  4. clean up AssignmentDetail,Edit screens and viewmodels (commit: ab0b104) (details)
  5. Remove role selection from admin add teacher subflow. (commit: d35ef22) (details)
  6. remove getAssignmentSummaries function (commit: 38a8e9c) (details)
  7. Implement initial version of getAssignmentProgress (commit: de2604a) (details)
  8. refactor (commit: b3ba8ae) (details)
  9. Add xapiAgent property to RespectSessionAndPerson (commit: 5f10957) (details)
  10. resolve conflicts (commit: f92dde8) (details)
  11. Add Uuid opt-in to respect-app-compose and respect-lib-shared. (commit: 7827d2b) (details)
  12. Add studentsXapiGroup function (commit: 7a93561) (details)
  13. Update Maestro flows for assignment and class management to use dynamic class names. (commit: 1a17fd5) (details)
  14. Update Maestro flows to reduce the number of students in the assignment test class. (commit: 4b36db7) (details)
  15. Add xapiAgent property to RespectSessionAndPerson (commit: 654d2ab) (details)
  16. Add Uuid opt-in to respect-app-compose and respect-lib-shared. (commit: 02599de) (details)
  17. Add studentsXapiGroup function (commit: e4e4f66) (details)
  18. refactor (commit: 86a8af5) (details)
  19. fix ui (commit: d8ebfba) (details)
  20. Fix XapiStatementEntityDao (commit: 81f3154) (details)
  21. Fix XapiStatementEntityDao (commit: 2e51e61) (details)
  22. Fix XapiActorExt.distinctMerged function (commit: 39869b4) (details)
  23. Update Maestro test flows for assignments and move onboarding tests to pending. (commit: 4318a7f) (details)
  24. Fix mistake on XapiStatementEntityDao get assignment progress function: incorrect use of group. (commit: 04eeca8) (details)
  25. Make assignment progress query test more rigorous. (commit: b0a5249) (details)
  26. Implement creation of an XapiGroup for students in a given class to enable assignments to work as expected. (commit: 7f5e45c) (details)
Commit 07731c383a17fb4a0b24db0e760868b6e3acd65d by noreply
Add guideline on understanding code before committing

Added guideline about understanding and explaining code before committing.
(commit: 07731c3)
The file was modifiedCODING_GUIDELINES.md (diff)
Commit 18b1fed572b7f8d297d29d9835b62ce9433d97f7 by noreply
Clarify variable usage in coding guidelines

Added guideline to avoid using two variables for the same purpose.
(commit: 18b1fed)
The file was modifiedCODING_GUIDELINES.md (diff)
Commit 5faf3ac280de655c20c419f87c90a788297e0488 by Mike Dawson
Update AGENTS.md to refer to CODING_GUIDELINES.md
(commit: 5faf3ac)
The file was modifiedAGENTS.md (diff)
Commit ab0b104794b6ed600926a6401b05c2145eaf589b by Anugraha
clean up AssignmentDetail,Edit screens and viewmodels
(commit: ab0b104)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/detail/AssignmentDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/list/AssignmentListViewModel.kt (diff)
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/AssignmentResultExt.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/edit/AssignmentEditViewModel.kt (diff)
Commit d35ef225c00a65c9e306ed535860bf32d6ee3f62 by Pooja Ravi
Remove role selection from admin add teacher subflow.
(commit: d35ef22)
The file was modified.maestro/flows/subflows/admin_add_new_teacher_to_class.yaml (diff)
Commit 38a8e9c183bc703790887dd24b24959f923d2a4f by Anugraha
remove getAssignmentSummaries function
(commit: 38a8e9c)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/resources/XapiStatementsResource.kt (diff)
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/xapi/XapiStatementsResourceHttp.kt (diff)
The file was modifiedrespect-datalayer-repository/src/commonMain/kotlin/world/respect/datalayer/repository/school/xapi/XapiStatementsResourceRepository.kt (diff)
The file was removedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/entities/XapiAssignmentSummaryEntityRow.kt
The file was removedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/model/XapiAssignmentConstants.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/list/AssignmentListViewModel.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
Commit de2604a5d24886f12e1eb367420d2fadfc323bea by Mike Dawson
Implement initial version of getAssignmentProgress
(commit: de2604a)
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/composites/XapiActorAndAssignmentProgress.kt
The file was addedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/composites/XapiAssignmentResultRow.kt
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiStatementExt.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
The file was addedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/adapters/XapiAssignmentResultRowAdapter.kt
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/xapi/XapiStatementsResourceHttp.kt (diff)
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/composites/XapiAssignmentProgress.kt
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/resources/XapiStatementsResource.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
The file was modifiedrespect-datalayer-repository/src/commonMain/kotlin/world/respect/datalayer/repository/school/xapi/XapiStatementsResourceRepository.kt (diff)
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiConstants.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/list/AssignmentListViewModel.kt (diff)
Commit 5f10957c07e8780e0f37aa70d3caf1d0d0b707ea by Mike Dawson
Add xapiAgent property to RespectSessionAndPerson
(commit: 5f10957)
The file was modifiedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/xapi/getxapilaunchurl/GetXapiLaunchUrlUseCaseAndroid.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/RespectSessionAndPerson.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/detail/AssignmentDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
Commit 7827d2b6a33d40da5aa71e650b7829df332a58d0 by Mike Dawson
Add Uuid opt-in to respect-app-compose and respect-lib-shared.
(commit: 7827d2b)
The file was modifiedrespect-app-compose/build.gradle.kts (diff)
The file was modifiedrespect-lib-shared/build.gradle.kts (diff)
Commit 7a93561a33094be6b42cea2d81d6731ef31335a4 by Mike Dawson
Add studentsXapiGroup function
(commit: 7a93561)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/ClazzExt.kt
Commit 1a17fd5a6a683ac4c5b407663b9723ae30310b44 by Pooja Ravi
Update Maestro flows for assignment and class management to use dynamic class names.
(commit: 1a17fd5)
The file was modified.maestro/flows/003_admin_user_assigns_assignment_to_a_class_test.yaml (diff)
The file was modified.maestro/flows/subflows/admin_add_new_student_to_class.yaml (diff)
The file was modified.maestro/flows/subflows/admin_add_class_with_members.yaml (diff)
The file was modified.maestro/flows/subflows/admin_add_new_teacher_to_class.yaml (diff)
Commit 4b36db7f8770355257894aa742542f8159510751 by Pooja Ravi
Update Maestro flows to reduce the number of students in the assignment test class.
(commit: 4b36db7)
The file was modified.maestro/flows/003_admin_user_assigns_assignment_to_a_class_test.yaml (diff)
The file was modified.maestro/flows/subflows/admin_add_class_with_members.yaml (diff)
Commit 654d2ab04aa1a087dc6f33a0dff7f97dc2ab2527 by Anugraha
Add xapiAgent property to RespectSessionAndPerson
(commit: 654d2ab)
The file was modifiedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/xapi/getxapilaunchurl/GetXapiLaunchUrlUseCaseAndroid.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/RespectSessionAndPerson.kt (diff)
Commit 02599de5e3e936c79767dd23b205fb086f3a0d02 by Anugraha
Add Uuid opt-in to respect-app-compose and respect-lib-shared.
(commit: 02599de)
The file was modifiedrespect-lib-shared/build.gradle.kts (diff)
The file was modifiedrespect-app-compose/build.gradle.kts (diff)
Commit e4e4f664c0ce6fcef528680817169d27173dc10e by Anugraha
Add studentsXapiGroup function
(commit: e4e4f66)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/ClazzExt.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/edit/AssignmentEditViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/detail/AssignmentDetailScreen.kt (diff)
Commit 81f315480906410a35e706d6b9102c1e64076aaa by Mike Dawson
Fix XapiStatementEntityDao

The Xapi search query used Join XapiVerbEntity instead of left join. The XapiVerbEntity is only created when a verb has display properties.

This broke the query such that statements that used verbs that had no display properties would not be returned.
(commit: 81f3154)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
Commit 2e51e61093b64abdb3ce834e8f8166cc86dc2eca by Mike Dawson
Fix XapiStatementEntityDao

The Xapi search query used Join XapiVerbEntity instead of left join. The XapiVerbEntity is only created when a verb has display properties.

This broke the query such that statements that used verbs that had no display properties would not be returned.
(commit: 2e51e61)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/entities/XapiVerbEntity.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/composites/XapiStatementAndJsonEntities.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
Commit 39869b40a763fc14c8e02094fe373e2b93accd8c by Mike Dawson
Fix XapiActorExt.distinctMerged function

DistinctMerged function was not handling identified groups correctly: the returned group member was not null even if it was null in the input. This caused the ActorDataSource to incorrectly remove all group members.
(commit: 39869b4)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/xapi/ext/XapiActorExt.kt (diff)
Commit 4318a7f11ca89d0d8b2bb7a559306e549484ed37 by Pooja Ravi
Update Maestro test flows for assignments and move onboarding tests to pending.
(commit: 4318a7f)
The file was removed.maestro/flows/001_003_login_using_school_link_test.yaml
The file was removed.maestro/flows/001_005_add_school_self_registration_test.yaml
The file was added.maestro/pending-flows/001_005_add_school_self_registration_test.yaml
The file was modified.maestro/flows/003_admin_user_assigns_assignment_to_a_class_test.yaml (diff)
The file was added.maestro/pending-flows/001_003_login_using_school_link_test.yaml
The file was removed.maestro/flows/002_browse_lessons_test.yaml
The file was added.maestro/pending-flows/002_browse_lessons_test.yaml
The file was added.maestro/pending-flows/001_002_add_user_direct_test.yaml
The file was removed.maestro/flows/001_001_invite_users_using_qr_code_or_link_test.yaml
The file was added.maestro/pending-flows/001_001_invite_users_using_qr_code_or_link_test.yaml
The file was removed.maestro/flows/001_002_add_user_direct_test.yaml
Commit 04eeca8a1ead36288a2a1371e6a859324e142699 by Mike Dawson
Fix mistake on XapiStatementEntityDao get assignment progress function: incorrect use of group.
(commit: 04eeca8)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/model/XapiVerb.kt (diff)
Commit b0a5249bb832437f50727267f631375474f1f233 by Mike Dawson
Make assignment progress query test more rigorous.
(commit: b0a5249)
The file was modifiedrespect-datalayer-db/src/jvmTest/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDbTest.kt (diff)
Commit 7f5e45c59ec11eb38383a9d4c8e1b9ec84c576d6 by Mike Dawson
Implement creation of an XapiGroup for students in a given class to enable assignments to work as expected.
(commit: 7f5e45c)
The file was modifiedrespect-datalayer-db/src/jvmTest/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDbTest.kt (diff)
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/model/XapiVerb.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiActorDataSourceDb.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/enrollments/UpdateClazzStudentXapiGroupUseCase.kt
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/ext/PersonExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/ClazzExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/RespectAccountManager.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/invite/ApproveOrDeclineInviteRequestUseCase.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/invite/RedeemInviteUseCaseDb.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/ServerKoinModule.kt (diff)