Skip to content
Failed

Changes

Summary

  1. fixes for the issues (details)
  2. error message showing now if registration allowed without adding terms (details)
  3. e2e_cypress test (details)
  4. test update - cypress (details)
  5. test update - maestro (details)
  6. when registration allowed toggle is off then error message was till showing so that is fixed in this commit (details)
  7. Modified test flow on cypress (details)
  8. Modified test description (details)
  9. Modified maestro test (details)
  10. test update - cypress - added wait to give time to load the switch (details)
  11. #comment time to load the switch (details)
  12. removed wait and force:true from cypress test (details)
  13. code cleanup (details)
  14. updated SiteEditScreen (details)
  15. Update Android Gradle Plugin version to 8.11.0 (details)
  16. clean up (details)
  17. Minor space tidyup and variable renaming. (details)
  18. changes in SendConsentRequestToParentUseCase (details)
  19. primary (details)
Commit a037886e47fe544ae3b524dcf975110c87a9c754 by nikunj.sharma
fixes for the issues
when user cancel app getting closed
https://github.com/UstadMobile/UstadMobile/issues/1114

when user cancel we dont need to show error messgae

https://github.com/UstadMobile/UstadMobile/issues/1113
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/login/LoginViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/person/manageaccount/ManageAccountViewModel.kt (diff)
The file was modifiedlib-ui-compose/src/commonMain/kotlin/com/ustadmobile/libuicompose/view/signup/OtherSignUpOptionSelectionScreen.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyUseCase.kt (diff)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/GetCredentialUseCaseImpl.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/GetCredentialUseCase.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/addaccountselectneworexisting/AddAccountSelectNewOrExistingViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/OtherSignUpOptionSelectionViewModel.kt (diff)
Commit 5e43efcde580e372aee41549b9a5a5a588bf550e by nikunj.sharma
error message showing now if registration allowed without adding terms
The file was modifiedapp-react/src/jsMain/kotlin/com/ustadmobile/view/site/edit/SiteEditScreen.kt (diff)
The file was modifiedtest-end-to-end/webapp-cypress/cypress/support/commands.js (diff)
Commit c6ed78e158304d816c88decc5ffd2dbaa68267b1 by Pooja Ravi
 test update - cypress
The file was modifiedtest-end-to-end/webapp-cypress/cypress/support/commands.js (diff)
Commit 0a66cbccbde52ca6a7c42097c66512e270c6bc84 by Pooja Ravi
 test update - maestro
The file was modifiedtest-end-to-end/android-maestro/e2e-tests/common/enable_user_registration.yaml (diff)
The file was modifiedtest-end-to-end/webapp-cypress/cypress/support/commands.js (diff)
Commit be4e253bfc7a685faaada89f19e08681ab127658 by nikunj.sharma
when registration allowed toggle is off then error message was till showing so that is fixed in this commit
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/site/edit/SiteEditViewModel.kt (diff)
Commit 52413d45320577828348fd304405f3e388a04a63 by Pooja Ravi
Modified test flow on cypress
The file was modifiedtest-end-to-end/webapp-cypress/cypress/support/commands.js (diff)
The file was modifiedtest-end-to-end/webapp-cypress/cypress/e2e/WEB_007_001_admin_enable_or_disable_user_registration.cy.js (diff)
Commit 19203f6558ad4921871e9ac3c6494af927130d5c by Pooja Ravi
Modified test description
The file was modifiedtest-end-to-end/test-descriptions/007_001_admin_enable_or_disable_user_registration_test_description.md (diff)
The file was modifiedtest-end-to-end/android-maestro/e2e-tests/007_001_admin_enable_or_disable_user_registration.yaml (diff)
The file was modifiedtest-end-to-end/android-maestro/e2e-tests/common/enable_user_registration.yaml (diff)
Commit d99c47010b6f37074f92484b101c0790259d9ee2 by Pooja Ravi
 test update - cypress - added wait to give time to load the switch
The file was modifiedtest-end-to-end/webapp-cypress/cypress/support/commands.js (diff)
The file was modifiedtest-end-to-end/webapp-cypress/cypress/e2e/WEB_007_001_admin_enable_or_disable_user_registration.cy.js (diff)
Commit 1d7057495ffdd25728a76fb903448e2138b85a20 by Pooja Ravi
 #comment time to load the switch
The file was modifiedtest-end-to-end/webapp-cypress/cypress/e2e/WEB_007_001_admin_enable_or_disable_user_registration.cy.js (diff)
Commit a149ad99b7e5b7073d1aa663726e68d94d5537cd by Pooja Ravi
removed wait and force:true from cypress test
The file was modifiedtest-end-to-end/webapp-cypress/cypress/e2e/WEB_007_001_admin_enable_or_disable_user_registration.cy.js (diff)
The file was modifiedtest-end-to-end/webapp-cypress/cypress/support/commands.js (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/addaccountselectneworexisting/AddAccountSelectNewOrExistingViewModel.kt (diff)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/OtherSignUpOptionSelectionViewModel.kt (diff)
The file was modifiedapp-react/src/jsMain/kotlin/com/ustadmobile/view/person/manageaccount/ManageAccountScreen.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyUseCase.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/person/manageaccount/ManageAccountViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt (diff)
The file was modifiedlib-ui-compose/src/commonMain/kotlin/com/ustadmobile/libuicompose/view/person/manageaccount/ManageAccountScreen.kt (diff)
The file was modifiedapp-react/src/jsMain/kotlin/com/ustadmobile/view/site/edit/SiteEditScreen.kt (diff)
Commit f66cceccd22d0735df89bc030bec4f15a80fdbed by Mike Dawson
Update Android Gradle Plugin version to 8.11.0
The file was modifiedbuild.gradle (diff)
The file was modifiedgradle/wrapper/gradle-wrapper.properties (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/login/LoginViewModel.kt (diff)
Commit 4a391368d3757f68635965d4ddda2c9a0b789ec1 by Mike Dawson
Minor space tidyup and variable renaming.
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/person/manageaccount/ManageAccountViewModel.kt (diff)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/OtherSignUpOptionSelectionViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt (diff)
Commit a803b39b840a001d5ad3cb4085c38b7664c089e4 by nikunj.sharma
changes in SendConsentRequestToParentUseCase
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/account/SendConsentRequestToParentUseCase.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/addaccountselectneworexisting/AddAccountSelectNewOrExistingViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/OtherSignUpOptionSelectionViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/person/child/ChildProfileListViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/list/AccountListViewModel.kt (diff)
The file was modifiedapp-ktor-server/src/main/kotlin/com/ustadmobile/lib/rest/domain/account/SendConsentRequestToParentServerImpl.kt (diff)
The file was modifiedlib-database/src/commonMain/kotlin/com/ustadmobile/core/db/dao/PersonParentJoinDao.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignupEnterUsernamePasswordViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/OtherSignUpOptionSelectionViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt (diff)