Skip to content
[Jenkins]Jenkins
log in
Success

Changes

Summary

  1. username suggestions added (commit: b8ec4ee) (details)
  2. Kotlinx Serialization Classes for WebAuthn Passkey Response (commit: ca2dee9) (details)
  3. changes in GetCredentialUseCaseImpl (commit: e609f90) (details)
  4. CreatePasskey use case should be returning the webauthn response (commit: d1dbaa8) (details)
  5. added UsernameSuggestionUseCase (commit: 4e53f26) (details)
  6. spec added (commit: 17c2b60) (details)
  7. Refactor passkey rpId and user id handling: (commit: 9e20fad) (details)
  8. changed the name of PasskeyWebAuthNResponse according to spec (commit: ee491d6) (details)
  9. Move webauthn model into model package. (commit: e9652b1) (details)
  10. user handle encoding decoding added with test (commit: 6d684cc) (details)
  11. clean up encoding decoding (commit: ccb7cba) (details)
  12. Fix SavePersonPasskeyUseCase compilation (commit: 908588c) (details)
  13. username issue fixed for web (commit: 40e3bfc) (details)
  14. Fix AbstractAppActivity compilation and remove CreatePasskeyRequestJsonUseCase from desktop and web DI. (commit: 12bbd2f) (details)
  15. Minor tidyup - remove commented out code etc. (commit: f7c5868) (details)
  16. Remove unused json codegen dependency. (commit: 5c8f8ca) (details)
  17. Remove diff in UmAppDatabaseMigrations . (commit: 17ad52d) (details)
The file was modifiedlib-ui-compose/src/commonMain/kotlin/com/ustadmobile/libuicompose/view/signup/SignUpScreen.kt (diff)
The file was addedapp-ktor-server/src/main/kotlin/com/ustadmobile/lib/rest/domain/username/UsernameSuggestionRoute.kt
The file was addedcore/src/jvmTest/kotlin/com/ustadmobile/core/username/UsernameSuggestionUseCaseTest.kt
The file was modifiedapp-react/src/jsMain/kotlin/com/ustadmobile/view/signup/SignUpScreen.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/impl/di/CommonDomainModule.kt (diff)
The file was modifiedapp-ktor-server/src/main/kotlin/com/ustadmobile/lib/rest/UmRestApplication.kt (diff)
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/username/GetUsernameSuggestionUseCase.kt
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/username/UsernameSuggestionUseCase.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/impl/di/CommonClientDomainModule.kt (diff)
Commit ca2dee9c7dab5194773a7eed9900c9f350b8a7d0 by nikunj.sharma
Kotlinx Serialization Classes for WebAuthn Passkey Response
 (commit: ca2dee9)
The file was modifiedapp-android/src/main/java/com/ustadmobile/port/android/view/AbstractAppActivity.kt (diff)
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/ClientDataJSON.kt
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/Prf.kt
The file was modifiedgradle/libs.versions.toml (diff)
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/ClientExtensionResults.kt
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/Response.kt
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/PasskeyWebAuthNResponse.kt
The file was modifiedcore/build.gradle (diff)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt (diff)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/GetCredentialUseCaseImpl.kt (diff)
Commit e609f9092db16c9d330cadbeddc9cfcc04328309 by nikunj.sharma
changes in GetCredentialUseCaseImpl
 (commit: e609f90)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/Response.kt (diff)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt (diff)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/GetCredentialUseCaseImpl.kt (diff)
Commit d1dbaa87d84f67b23be1621c04d73aacc1d6f59d by nikunj.sharma
CreatePasskey use case should be returning the webauthn response
Creating a passkey - use case parameter should be only the username
 (commit: d1dbaa8)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyRequestJsonUseCase.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt (diff)
The file was modifiedapp-react/src/jsMain/kotlin/com/ustadmobile/view/signup/SignUpEnterUsernamePasswordScreen.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/account/UstadAccountManager.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyUseCase.kt (diff)
The file was modifiedlib-ui-compose/src/commonMain/kotlin/com/ustadmobile/libuicompose/view/signup/SignUpEnterUsernamePasswordScreen.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignupEnterUsernamePasswordViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/SavePersonPasskeyUseCase.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/OtherSignUpOptionSelectionViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/person/manageaccount/ManageAccountViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyParams.kt (diff)
The file was modifiedapp-android/src/main/java/com/ustadmobile/port/android/impl/UstadApp.kt (diff)
Commit 4e53f267c642ec2fafa86d6573314f70ff8d1019 by nikunj.sharma
added UsernameSuggestionUseCase
 (commit: 4e53f26)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/username/UsernameSuggestionUseCase.kt (diff)
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/username/helper/UsernameErrorException.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/PasskeyWebAuthNResponse.kt (diff)
Commit 9e20fad4ead4cdf4116aef872bd764dd65832c76 by Mike Dawson
Refactor passkey rpId and user id handling:

Update CreatePublicKeyCredentialCreationOptionsJsonUseCase - set the user handle (user id) as passkeyUid@learningspace - as per the spec avoiding the use of any personal information, but including the server url.

Remove rpId from PersonPasskey (this is system wide, not a per entity variable).
 (commit: 9e20fad)
The file was modifiedlib-database/src/commonMain/kotlin/com/ustadmobile/lib/db/entities/PersonPasskey.kt (diff)
The file was modifiedlib-database/src/commonMain/kotlin/com/ustadmobile/core/db/ext/UmAppDatabaseMigrations.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/request/CreatePublicKeyCredentialCreationOptionsJsonUseCase.kt (diff)
Commit ee491d68ca69202c48738d7ad4d44ce5a1ed0648 by nikunj.sharma
changed the name of PasskeyWebAuthNResponse according to spec
change in the flow of signin with passkey
 (commit: ee491d6)
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/AuthenticationExtensionsPRFOutputsJSON.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyRequestJsonUseCase.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/login/LoginViewModel.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/account/UstadAccountManager.kt (diff)
The file was removedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyParams.kt
The file was removedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/PasskeyWebAuthNResponse.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/person/manageaccount/ManageAccountViewModel.kt (diff)
The file was modifiedapp-android/src/main/java/com/ustadmobile/port/android/impl/UstadApp.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/addaccountselectneworexisting/AddAccountSelectNewOrExistingViewModel.kt (diff)
The file was removedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/ClientExtensionResults.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/OtherSignUpOptionSelectionViewModel.kt (diff)
The file was removedcore/src/jvmTest/kotlin/com/ustadmobile/core/domain/xapi/formatresponse/FormatStatementResponseUseCaseTest.kt
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/AuthenticationResponseJSON.kt
The file was modifiedcore/build.gradle (diff)
The file was removedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/Prf.kt
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/GetCredentialUseCaseImpl.kt (diff)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt (diff)
The file was modifiedlib-database/schemas/com.ustadmobile.core.db.UmAppDatabase/207.json (diff)
The file was modifiedapp-android/src/main/java/com/ustadmobile/port/android/view/AbstractAppActivity.kt (diff)
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/AuthenticationExtensionsClientOutputsJSON.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/ClientDataJSON.kt (diff)
The file was removedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/Response.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/GetCredentialUseCase.kt (diff)
The file was modifiedgradle/libs.versions.toml (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyUseCase.kt (diff)
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/AuthenticatorAssertionResponseJSON.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/SavePersonPasskeyUseCase.kt (diff)
The file was addedcore/src/jvmTest/kotlin/com/ustadmobile/core/domain/xapi/formatresponse/FormatStatementAuthenticatorAssertionResponseJSONUseCaseTest.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt (diff)
Commit e9652b14275ff728a8ebecc75e96dfdc7833b038 by Mike Dawson
Move webauthn model into model package.
 (commit: e9652b1)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/account/UstadAccountManager.kt (diff)
The file was removedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/AuthenticationResponseJSON.kt
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/model/AuthenticationExtensionsPRFOutputsJSON.kt
The file was removedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/AuthenticatorAssertionResponseJSON.kt
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/model/AuthenticationResponseJSON.kt
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/CreatePasskeyUseCaseImpl.kt (diff)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/GetCredentialUseCaseImpl.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/CreatePasskeyUseCase.kt (diff)
The file was removedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/AuthenticationExtensionsPRFOutputsJSON.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/GetCredentialUseCase.kt (diff)
The file was removedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/AuthenticationExtensionsClientOutputsJSON.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/SavePersonPasskeyUseCase.kt (diff)
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/model/ClientDataJSON.kt
The file was removedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/webAuthn/ClientDataJSON.kt
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/model/AuthenticationExtensionsClientOutputsJSON.kt
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/model/AuthenticatorAssertionResponseJSON.kt
Commit 6d684ccb65a0e58f951a3cdcb1849ecfc6277fd1 by nikunj.sharma
user handle encoding decoding added with test
 (commit: 6d684cc)
The file was addedcore/src/commonJvmMain/kotlin/com/ustadmobile/core/domain/passkey/DecodeUserHandleUseCaseImpl.kt
The file was addedcore/src/jvmTest/kotlin/com/ustadmobile/core/domain/passkey/EncodeDecodeUserHandleUseCaseTest.kt
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/account/addaccountselectneworexisting/AddAccountSelectNewOrExistingViewModel.kt (diff)
The file was modifiedapp-android/src/main/java/com/ustadmobile/port/android/view/AbstractAppActivity.kt (diff)
The file was modifiedapp-desktop/src/main/java/com/ustadmobile/port/desktop/DesktopDomainDiModule.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/request/CreatePublicKeyCredentialCreationOptionsJsonUseCase.kt (diff)
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/DecodeUserHandleUseCase.kt
The file was addedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/EncodeUserHandleUseCase.kt
The file was addedcore/src/commonJvmMain/kotlin/com/ustadmobile/core/domain/passkey/EncodeUserHandleUseCaseImpl.kt
The file was modifiedapp-ktor-server/src/main/kotlin/com/ustadmobile/lib/rest/domain/passkey/verify/VerifySignInWithPasskeyRoute.kt (diff)
The file was modifiedcore/src/commonJvmMain/kotlin/com/ustadmobile/core/domain/passkey/DecodeUserHandleUseCaseImpl.kt (diff)
The file was modifiedapp-ktor-server/src/main/kotlin/com/ustadmobile/lib/rest/UmRestApplication.kt (diff)
The file was modifiedcore/src/jvmTest/kotlin/com/ustadmobile/core/domain/passkey/EncodeDecodeUserHandleUseCaseTest.kt (diff)
The file was modifiedapp-ktor-server/src/main/kotlin/com/ustadmobile/lib/rest/domain/passkey/verify/VerifySignInWithPasskeyUseCase.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/account/UstadAccountManager.kt (diff)
The file was modifiedcore/src/commonJvmMain/kotlin/com/ustadmobile/core/domain/passkey/EncodeUserHandleUseCaseImpl.kt (diff)
Commit 908588cb2f8f04ee00d1f57167b511204af60c9d by Mike Dawson
Fix SavePersonPasskeyUseCase compilation
 (commit: 908588c)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/domain/credentials/SavePersonPasskeyUseCase.kt (diff)
The file was modifiedapp-react/src/jsMain/kotlin/com/ustadmobile/view/signup/SignUpScreen.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/viewmodel/signup/SignUpViewModel.kt (diff)
Commit 12bbd2fdc6e847bf26d9e8a3622f5e4f22196a0e by Mike Dawson
Fix AbstractAppActivity compilation and remove CreatePasskeyRequestJsonUseCase from desktop and web DI.
 (commit: 12bbd2f)
The file was modifiedapp-desktop/src/main/java/com/ustadmobile/port/desktop/DesktopDomainDiModule.kt (diff)
The file was modifiedcore/src/androidMain/kotlin/com/ustadmobile/core/domain/credentials/passkey/GetCredentialUseCaseImpl.kt (diff)
The file was modifiedcore/src/jsMain/kotlin/com/ustadmobile/core/impl/di/DomainDiModuleJs.kt (diff)
The file was modifiedapp-android/src/main/java/com/ustadmobile/port/android/view/AbstractAppActivity.kt (diff)
Commit f7c5868fc4f88bf520b5564e93464c6c0484de89 by Mike Dawson
Minor tidyup - remove commented out code etc.
 (commit: f7c5868)
The file was modifiedcore/src/jvmTest/kotlin/com/ustadmobile/core/username/UsernameSuggestionUseCaseTest.kt (diff)
The file was modifiedapp-ktor-server/src/main/kotlin/com/ustadmobile/lib/rest/domain/passkey/verify/VerifySignInWithPasskeyRoute.kt (diff)
The file was modifiedcore/src/commonMain/kotlin/com/ustadmobile/core/account/UstadAccountManager.kt (diff)
The file was modifiedapp-ktor-server/src/main/kotlin/com/ustadmobile/lib/rest/domain/passkey/verify/VerifySignInWithPasskeyUseCase.kt (diff)
Commit 5c8f8cabb797b2e0e4eea2a0412d662be67317ed by Mike Dawson
Remove unused json codegen dependency.
 (commit: 5c8f8ca)
The file was modifiedcore/build.gradle (diff)
The file was modifiedgradle/libs.versions.toml (diff)
Commit 17ad52d058547034a7efe84ee988cbd3a4281911 by Mike Dawson
Remove diff in UmAppDatabaseMigrations .
 (commit: 17ad52d)
The file was modifiedlib-database/src/commonMain/kotlin/com/ustadmobile/core/db/ext/UmAppDatabaseMigrations.kt (diff)