Skip to content

Changes

Started by timer
Started 7 hr 45 min ago
Took 20 min

Summary

  1. Fix XapiStatementEntityDao (details)
  2. Fix XapiStatementEntityDao (details)
  3. Fix XapiActorExt.distinctMerged function (details)
  4. Fix mistake on XapiStatementEntityDao get assignment progress function: incorrect use of group. (details)
  5. Make assignment progress query test more rigorous. (details)
  6. Implement creation of an XapiGroup for students in a given class to enable assignments to work as expected. (details)
  7. Replaced showAddStudent, showAddTeacher, and showStudentGrouping with a single isAdminOrTeacher because all three were always set to the exact same value. (details)
  8. Refine log messages (details)
  9. Remove the app url argument from Learning Unit Detail screen. This should not be required. (details)
  10. Add GetXapiActivityForPublicationUseCase and related readme. (details)
  11. Refine log messages (details)
  12. Update assignment recipe example. (details)
  13. Add `STACK_COUNT` constant to `ClazzDetailViewModel` and use it to limit member display in `ClazzDetailScreen`. (details)
Commit 81f315480906410a35e706d6b9102c1e64076aaa by Mike Dawson
Fix XapiStatementEntityDao

The Xapi search query used Join XapiVerbEntity instead of left join. The XapiVerbEntity is only created when a verb has display properties.

This broke the query such that statements that used verbs that had no display properties would not be returned.
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
Commit 2e51e61093b64abdb3ce834e8f8166cc86dc2eca by Mike Dawson
Fix XapiStatementEntityDao

The Xapi search query used Join XapiVerbEntity instead of left join. The XapiVerbEntity is only created when a verb has display properties.

This broke the query such that statements that used verbs that had no display properties would not be returned.
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/composites/XapiStatementAndJsonEntities.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/entities/XapiVerbEntity.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
Commit 39869b40a763fc14c8e02094fe373e2b93accd8c by Mike Dawson
Fix XapiActorExt.distinctMerged function

DistinctMerged function was not handling identified groups correctly: the returned group member was not null even if it was null in the input. This caused the ActorDataSource to incorrectly remove all group members.
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/xapi/ext/XapiActorExt.kt (diff)
Commit 04eeca8a1ead36288a2a1371e6a859324e142699 by Mike Dawson
Fix mistake on XapiStatementEntityDao get assignment progress function: incorrect use of group.
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/model/XapiVerb.kt (diff)
Commit b0a5249bb832437f50727267f631375474f1f233 by Mike Dawson
Make assignment progress query test more rigorous.
The file was modifiedrespect-datalayer-db/src/jvmTest/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDbTest.kt (diff)
Commit 7f5e45c59ec11eb38383a9d4c8e1b9ec84c576d6 by Mike Dawson
Implement creation of an XapiGroup for students in a given class to enable assignments to work as expected.
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/ClazzExt.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/enrollments/UpdateClazzStudentXapiGroupUseCase.kt
The file was modifiedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/invite/RedeemInviteUseCaseDb.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/ext/PersonExt.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/ServerKoinModule.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiActorDataSourceDb.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/RespectAccountManager.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/model/XapiVerb.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/invite/ApproveOrDeclineInviteRequestUseCase.kt (diff)
The file was modifiedrespect-datalayer-db/src/jvmTest/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDbTest.kt (diff)
Commit 2685c5be3f9de403ae71d0aa99fe89cce2fb61ec by mandvi.verma
Replaced showAddStudent, showAddTeacher, and showStudentGrouping with a single isAdminOrTeacher because all three were always set to the exact same value.
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.kt (diff)
Commit 5dfc66f1f8e4d4a53f4fab55d95ac9b67aab7768 by Mike Dawson
Remove the app url argument from Learning Unit Detail screen. This should not be required.
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/list/LearningUnitListViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/LearningUnitSelection.kt (diff)
The file was modifiedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchapp/LaunchAppUseCaseAndroid.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/detail/AppsDetailViewModel.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/model/AssignmentLearningUnitRef.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/AppRoutes.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/detail/LearningUnitDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/learningunit/detail/LearningUnitDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/opds/OpdsPublicationDataSourceHttp.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/opds/ext/ReadiumLinkExt.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/adapters/AssignmentAdapter.kt (diff)
The file was modifiedrespect-lib-opds-model/src/commonMain/kotlin/world/respect/lib/opds/model/OpdsPublicationExt.kt (diff)
The file was addedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/opds/ext/OpdsPublicationExt.kt
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/opds/ext/OpdsFeedExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchapp/LaunchAppUseCase.kt (diff)
The file was modifiedrespect-lib-xapi-core/README_ASSIGNMENT_RECIPE.md (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/edit/AssignmentEditViewModel.kt (diff)
Commit 2be5b5d4888c7fcb11c26e55025123cbd0251a70 by Mike Dawson
Add GetXapiActivityForPublicationUseCase and related readme.
The file was addedrespect-lib-xapi-core/README_EXTENSION_PUBLICATION.md
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/opds/getxapiactivityid/GetXapiActivityForPublicationUseCase.kt
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/OpenEelXapiConstants.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was modifiedrespect-lib-opds-model/src/commonMain/kotlin/world/respect/lib/opds/model/LangMapExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.kt (diff)
Commit af3beb9f6048b7c6c72f3d45ce998dd5574fab03 by Mike Dawson
Update assignment recipe example.
The file was modifiedrespect-lib-xapi-core/README_ASSIGNMENT_RECIPE.md (diff)
Commit 9bb25c66bce994472944c10392a4b7b77f33caad by mandvi.verma
Add `STACK_COUNT` constant to `ClazzDetailViewModel` and use it to limit member display in `ClazzDetailScreen`.
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)