Skip to content
Sign in

Changes

Started by timer
Started 12 days ago
Took 2 min 41 sec

Summary

  1. Fix mistake on xapi statement query: using incorrect verb field (commit: a500ce4) (details)
  2. Fix mistake on xapi resource: wrong parameter for until. (commit: df8580a) (details)
  3. Refactor `StudentGroupingDetailViewModel` and `StudentGroupingEditViewModel` to streamline account data handling and improve xAPI statement creation. (commit: 0f831ad) (details)
Commit a500ce454fb2ba95f7643cb028b8cfd7520e0dab by Mike Dawson
Fix mistake on xapi statement query: using incorrect verb field
 (commit: a500ce4)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityJsonDao.kt (diff)
Commit df8580a5381a93f08e6dbc95896003ad16b9888b by Mike Dawson
Fix mistake on xapi resource: wrong parameter for until.
 (commit: df8580a)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
Commit 0f831ad9493d387cf46c2a8fb465f6568b0da435 by mandvi.verma
Refactor `StudentGroupingDetailViewModel` and `StudentGroupingEditViewModel` to streamline account data handling and improve xAPI statement creation.

- Remove `selectedAccount` and helper properties from `StudentGroupingDetailUiState` and `StudentGroupingEditUiState`.
- Fetch the person data directly from `respectAccountManager.selectedAccountAndPersonFlow` when needed for xAPI statements.
- Replace `viewModelScope.launch` with `launchWithLoadingIndicator` in `onConfirmDeleteGroup` and `onSaveGroup`.
- Clean up the `StudentGroupingEditViewModel` initialization by removing the manual collection of the account flow.
- Format navigation logic in `StudentGroupingEditViewModel` for better readability.
 (commit: 0f831ad)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.kt (diff)