Skip to content

Changes

Started by timer
Started 6 days 18 hr ago
Took 1 min 43 sec

Summary

  1. Add Maestro flow summary documentation for core features. (commit: 507c9fb) (details)
  2. Update `.maestro/README.md` formatting. (commit: 426ab42) (details)
  3. Refactor Maestro test documentation by consolidating flow summaries. (commit: df4bd8e) (details)
  4. Update Maestro README.md to use numbered lists for test flow descriptions. (commit: c1bfccd) (details)
  5. Update Maestro README with detailed steps for user management and school registration test flows. (commit: efb7a28) (details)
  6. Change PERSON_ADMIN_WRITE flag to an explicit permission. Using a value that was not represented by a single 2^x value resulted in errors in the permission check queries not working as expected. (commit: 67d616e) (details)
  7. Fix for issue #231. (commit: 93e8ed5) (details)
  8. Fix mistake on xapi statement query: using incorrect verb field (commit: a500ce4) (details)
  9. Fix mistake on xapi resource: wrong parameter for until. (commit: df8580a) (details)
  10. Issue #231 (commit: de6e9a8) (details)
  11. Disable flow 003 until new xAPI based assignment branch is merged. (commit: 69f8132) (details)
  12. Check username unique during invitation acceptance process (issue #232). (commit: f57c392) (details)
  13. Apply username unique check to when admin sets a username manually. (commit: f80a98b) (details)
  14. Correct visibility of floating action button on PersonListViewModel.kt and update to use common GetWritableRolesUseCase (commit: 8f8b359) (details)
  15. Show role on PersonListScreen. (commit: 6252aff) (details)
  16. Show error snackbar when no valid link is found. (commit: ab5a99a) (details)
  17. Bump version and change assignment label. (commit: a3ad308) (details)
  18. Merge dev xapi (commit: 98c538d) (details)
  19. Clean up unused imports and string resources in `ClazzDetailScreen.kt`. (commit: 1c2be5c) (details)
Commit 507c9fb296572ecad9badcd988357fc80e9ab3c1 by Pooja Ravi
Add Maestro flow summary documentation for core features.
(commit: 507c9fb)
The file was added.maestro/flow-summary/001_003_login_using_school_link_test.md
The file was removedrespect-test-end-to-end/test-description/001_002_add_user_direct_test_description.md
The file was removedrespect-test-end-to-end/test-description/003_teacher_user_assigns_assignment_to_a_class_test_description.md
The file was removedrespect-test-end-to-end/test-description/006_user_signup_using_passkey_test_description.md
The file was removedrespect-test-end-to-end/test-description/001_001_invite_using_invite_code_test_description.md
The file was removedrespect-test-end-to-end/README.md
The file was removedrespect-test-end-to-end/test-description/001_005_add_school_self_registration_test_description.md
The file was removedrespect-test-end-to-end/test-description/001_003_login_using_school_link_test_description.md
The file was removedrespect-test-end-to-end/test-description/002_browse_lessons_test_description.md
The file was added.maestro/flow-summary/002_browse_lessons_test.md
The file was added.maestro/flow-summary/001_001_invite_users_using_qr_code_or_link_test.md
The file was modified.maestro/README.md (diff)
The file was added.maestro/flow-summary/001_005_add_school_self_registration_test.md
The file was added.maestro/flow-summary/003_admin_user_assigns_assignment_to_a_class_test.md
The file was added.maestro/flow-summary/001_002_add_user_direct_test.md
Commit 426ab425c9387e68a05bb151d74e49906521e977 by Pooja Ravi
Update `.maestro/README.md` formatting.
(commit: 426ab42)
The file was modified.maestro/README.md (diff)
Commit df4bd8e47a102ff17962776fc91467fe9276b59f by Pooja Ravi
Refactor Maestro test documentation by consolidating flow summaries.
(commit: df4bd8e)
The file was removed.maestro/flow-summary/001_001_invite_users_using_qr_code_or_link_test.md
The file was removed.maestro/flow-summary/003_admin_user_assigns_assignment_to_a_class_test.md
The file was removed.maestro/flow-summary/001_005_add_school_self_registration_test.md
The file was removed.maestro/flow-summary/001_002_add_user_direct_test.md
The file was removed.maestro/flow-summary/002_browse_lessons_test.md
The file was removed.maestro/flow-summary/001_003_login_using_school_link_test.md
The file was modified.maestro/README.md (diff)
Commit c1bfccdbe55284ca41957899c8bb93a7f3fdddad by Pooja Ravi
Update Maestro README.md to use numbered lists for test flow descriptions.
(commit: c1bfccd)
The file was modified.maestro/README.md (diff)
Commit efb7a28407916d1ed6c4a7ae740a0426c4cce9a1 by Pooja Ravi
Update Maestro README with detailed steps for user management and school registration test flows.
(commit: efb7a28)
The file was modified.maestro/README.md (diff)
Commit 67d616e77479b2ecf04a181441330e602a1cb6b7 by Mike Dawson
Change PERSON_ADMIN_WRITE flag to an explicit permission. Using a value that was not represented by a single 2^x value resulted in errors in the permission check queries not working as expected.

Permission check queries were using a binary and, then checking the result is greater than zero. This is fine when checking for a 2^x value, but not others.
(commit: 67d616e)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/ext/PersonRoleEnumExt.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/domain/GetWritableRolesListUseCaseImpl.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/daos/PersonEntityDao.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/domain/CheckPersonPermissionUseCase.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/model/PermissionFlags.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/edit/PersonEditViewModel.kt (diff)
Commit 93e8ed5b9f0b2414facb4a76d63f604d64d9a31b by Mike Dawson
Fix for issue #231.

When a teacher or any other is being approved, this requires permission to add the given user role. Teachers by default have permission to add students and parents, but not other teachers. They should therefor not see the option to approve a teacher registration (only admin can do that).
(commit: 93e8ed5)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/list/PersonListViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClassPendingPersonListItem.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/list/PersonListScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)
Commit a500ce454fb2ba95f7643cb028b8cfd7520e0dab by Mike Dawson
Fix mistake on xapi statement query: using incorrect verb field
(commit: a500ce4)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityJsonDao.kt (diff)
Commit df8580a5381a93f08e6dbc95896003ad16b9888b by Mike Dawson
Fix mistake on xapi resource: wrong parameter for until.
(commit: df8580a)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
Commit de6e9a83bbf380cc39f10da49e4bdca96d65a1fc by Mike Dawson
Issue #231

Fix logic error that prevented handling admin approval for teacher joining class. Student joining class was working as expected.
(commit: de6e9a8)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/ext/PersonExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/invite/ApproveOrDeclineInviteRequestUseCase.kt (diff)
Commit 69f813221401eb23ef0374d7ef62e1d649005926 by Mike Dawson
Disable flow 003 until new xAPI based assignment branch is merged.
(commit: 69f8132)
The file was added.maestro/flows-disabled/003_admin_user_assigns_assignment_to_a_class_test.yaml
The file was removed.maestro/flows/003_admin_user_assigns_assignment_to_a_class_test.yaml
Commit f57c392693352718885d4fc16cde4b3c71480fb5 by Mike Dawson
Check username unique during invitation acceptance process (issue #232).
(commit: f57c392)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/ServerKoinModule.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/signup/CreateAccountViewModel.kt (diff)
The file was addedrespect-server/src/main/kotlin/world/respect/server/account/invite/username/checkusernameunique/CheckUsernameUniqueUseCaseServer.kt
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/daos/PersonEntityDao.kt (diff)
The file was addedrespect-server/src/main/kotlin/world/respect/server/routes/username/checkusernameunique/CheckUsernameUniqueRoute.kt
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/username/checkusernameunique/CheckUsernameUniqueUseCaseClient.kt
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/username/checkusernameunique/CheckUsernameUniqueUseCase.kt
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/Application.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/manageuser/createaccount/CreateAccountScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
The file was modifiedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/invite/RedeemInviteUseCaseDb.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/account/invite/username/UsernameSuggestionUseCaseServer.kt (diff)
Commit f80a98b0700c71f29761383f0d1825474d323c49 by Mike Dawson
Apply username unique check to when admin sets a username manually.
(commit: f80a98b)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/setusernameandpassword/CreateAccountSetUserNameViewModel.kt (diff)
Commit 8f8b35910f242ef2abdf0ecc542df733be8f66dc by Mike Dawson
Correct visibility of floating action button on PersonListViewModel.kt and update to use common GetWritableRolesUseCase
(commit: 8f8b359)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/list/PersonListViewModel.kt (diff)
Commit 6252aff4599c9374493601a1ea8c1b0a520e2d37 by Mike Dawson
Show role on PersonListScreen.
When selecting people to add to class, filter by role (as per #237).
(commit: 6252aff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/ext/PersonExt.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/adapters/PersonAdapters.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/model/composites/PersonListDetails.kt (diff)
The file was addedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/list/PersonListItem.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/AppRoutes.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/list/PersonListScreen.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/daos/PersonEntityDao.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
Commit ab5a99a59234259c334be4a2fb2f86b32ba5f558 by Mike Dawson
Show error snackbar when no valid link is found.
Fix handling of opening lessons from horizontal pager on app detail screen (Issue #229).
(commit: ab5a99a)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/detail/AppsDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/detail/LearningUnitDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/composeResources/values/strings.xml (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/ReadiumLinkExt.kt (diff)
Commit a3ad308646f86af215e35299a44e2d6fb8a29738 by Mike Dawson
Bump version and change assignment label.
(commit: a3ad308)
The file was modifiedrespect-app-compose/build.gradle.kts (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/components/RespectLocalDateTimeField.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/assignment/edit/AssignmentEditScreen.kt (diff)
The file was removed.maestro/flows-disable/003_admin_user_assigns_assignment_to_a_class_test.yaml
Commit 1c2be5cfb15d36d6f8ae879154ae70144892782e by mandvi.verma
Clean up unused imports and string resources in `ClazzDetailScreen.kt`.
(commit: 1c2be5c)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)