Skip to content

Changes

Started by timer
Started 14 hr ago
Took 3 min 24 sec

Summary

  1. Add guideline on understanding code before committing (commit: 07731c3) (details)
  2. Clarify variable usage in coding guidelines (commit: 18b1fed) (details)
  3. Introduce `XapiStatementExt.kt` to centralize xAPI helper functions and refactor student grouping ViewModels. (commit: a93d8f5) (details)
  4. Remove unused `SchoolDataSource` import in `XapiStatementExt.kt`. (commit: a47996d) (details)
  5. Update AGENTS.md to refer to CODING_GUIDELINES.md (commit: 5faf3ac) (details)
  6. Implement initial version of getAssignmentProgress (commit: de2604a) (details)
  7. Add xapiAgent property to RespectSessionAndPerson (commit: 5f10957) (details)
  8. Add Uuid opt-in to respect-app-compose and respect-lib-shared. (commit: 7827d2b) (details)
  9. Remove unused `SchoolDataSource` import in `XapiStatementExt.kt`. (commit: fd555e5) (details)
  10. Add studentsXapiGroup function (commit: 7a93561) (details)
  11. Update group filtering logic in `ClazzDetailViewModel.kt` to handle null timestamps and ensure distinct groups are correctly mapped from xAPI statements. (commit: e686bec) (details)
  12. Remove `XapiStatementExt.kt` and inline xAPI agent and statement creation logic within `StudentGroupingDetailViewModel` and `StudentGroupingEditViewModel`. Use `xapiAgent` directly from the selected account session and manually construct `XapiStatement` and `XapiAgent` objects for group management and voiding operations. (commit: ebd422f) (details)
  13. Remove unnecessary empty lines in `ClazzDetailViewModel.kt`. (commit: b3324ae) (details)
  14. Apply minor formatting and whitespace adjustments to `ClazzDetailViewModel.kt`. (commit: b8a2ca2) (details)
  15. Improve error handling and data robustness in student grouping view models and screens. (commit: 129ac91) (details)
Commit 07731c383a17fb4a0b24db0e760868b6e3acd65d by noreply
Add guideline on understanding code before committing

Added guideline about understanding and explaining code before committing.
(commit: 07731c3)
The file was modifiedCODING_GUIDELINES.md (diff)
Commit 18b1fed572b7f8d297d29d9835b62ce9433d97f7 by noreply
Clarify variable usage in coding guidelines

Added guideline to avoid using two variables for the same purpose.
(commit: 18b1fed)
The file was modifiedCODING_GUIDELINES.md (diff)
Commit a93d8f58578f169f9b72317be29708607c910dcf by mandvi.verma
Introduce `XapiStatementExt.kt` to centralize xAPI helper functions and refactor student grouping ViewModels.
(commit: a93d8f5)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiStatementExt.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/studentgrouping/edit/StudentGroupingEditScreen.kt (diff)
Commit a47996dd06f5d2dcd1a6235ca362a94347fdaf01 by mandvi.verma
Remove unused `SchoolDataSource` import in `XapiStatementExt.kt`.
(commit: a47996d)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiStatementExt.kt (diff)
Commit 5faf3ac280de655c20c419f87c90a788297e0488 by Mike Dawson
Update AGENTS.md to refer to CODING_GUIDELINES.md
(commit: 5faf3ac)
The file was modifiedAGENTS.md (diff)
Commit de2604a5d24886f12e1eb367420d2fadfc323bea by Mike Dawson
Implement initial version of getAssignmentProgress
(commit: de2604a)
The file was addedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/adapters/XapiAssignmentResultRowAdapter.kt
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/composites/XapiAssignmentProgress.kt
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/resources/XapiStatementsResource.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiConstants.kt
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/ext/XapiStatementExt.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
The file was addedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/composites/XapiAssignmentResultRow.kt
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/xapi/XapiStatementsResourceHttp.kt (diff)
The file was addedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/composites/XapiActorAndAssignmentProgress.kt
The file was modifiedrespect-datalayer-repository/src/commonMain/kotlin/world/respect/datalayer/repository/school/xapi/XapiStatementsResourceRepository.kt (diff)
Commit 5f10957c07e8780e0f37aa70d3caf1d0d0b707ea by Mike Dawson
Add xapiAgent property to RespectSessionAndPerson
(commit: 5f10957)
The file was modifiedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/xapi/getxapilaunchurl/GetXapiLaunchUrlUseCaseAndroid.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/RespectSessionAndPerson.kt (diff)
Commit 7827d2b6a33d40da5aa71e650b7829df332a58d0 by Mike Dawson
Add Uuid opt-in to respect-app-compose and respect-lib-shared.
(commit: 7827d2b)
The file was modifiedrespect-app-compose/build.gradle.kts (diff)
The file was modifiedrespect-lib-shared/build.gradle.kts (diff)
Commit fd555e517d67bb2433e8ab75b059c60ba5b8cf77 by mandvi.verma
Remove unused `SchoolDataSource` import in `XapiStatementExt.kt`.
(commit: fd555e5)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/studentgrouping/edit/StudentGroupingEditScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.kt (diff)
Commit 7a93561a33094be6b42cea2d81d6731ef31335a4 by Mike Dawson
Add studentsXapiGroup function
(commit: 7a93561)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/ClazzExt.kt
Commit e686becd21c74ffff565a458fe7d198a258e71e8 by mandvi.verma
Update group filtering logic in `ClazzDetailViewModel.kt` to handle null timestamps and ensure distinct groups are correctly mapped from xAPI statements.
(commit: e686bec)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
Commit ebd422f539efa51cb39987b2eb0cc9b11acce039 by mandvi.verma
Remove `XapiStatementExt.kt` and inline xAPI agent and statement creation logic within `StudentGroupingDetailViewModel` and `StudentGroupingEditViewModel`. Use `xapiAgent` directly from the selected account session and manually construct `XapiStatement` and `XapiAgent` objects for group management and voiding operations.
(commit: ebd422f)
The file was removedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/xapi/XapiStatementExt.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.kt (diff)
Commit b3324ae44944ea82456668a43d5eca3c858bd1b2 by mandvi.verma
Remove unnecessary empty lines in `ClazzDetailViewModel.kt`.
(commit: b3324ae)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
Commit b8a2ca238c859dfde5d3b59a90a47617b74eeb03 by mandvi.verma
Apply minor formatting and whitespace adjustments to `ClazzDetailViewModel.kt`.
(commit: b8a2ca2)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
Commit 129ac91e8fef8241b6904a66183ea6ab8067e7be by mandvi.verma
Improve error handling and data robustness in student grouping view models and screens.

- Add `Napier` logging and replace potential crashes with safe checks and early returns in `StudentGroupingDetailViewModel`, `ClazzDetailViewModel`, and `StudentGroupingEditViewModel`.
- Refactor `StudentGroupingEditState` to calculate `selectedStudentIds` dynamically from the student list.
- Enhance group filtering and mapping logic in `ClazzDetailViewModel` to handle missing group/member data gracefully.
- Update UI components in `StudentGroupingEditScreen` and `ClazzDetailScreen` to safely handle null items and improve key mapping.
- Delete unused `XapiActorDataSource.kt`.
(commit: 129ac91)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/studentgrouping/edit/StudentGroupingEditScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/edit/StudentGroupingEditViewModel.kt (diff)
The file was removedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/xapi/XapiActorDataSource.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/studentgrouping/detail/StudentGroupingDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/clazz/detail/ClazzDetailScreen.kt (diff)