Skip to content
Sign in

Changes

Started by timer
Started 1 day 8 hr ago
Took 2 min 14 sec

Summary

  1. Fix XapiStatementEntityDao (commit: 81f3154) (details)
  2. Fix XapiStatementEntityDao (commit: 2e51e61) (details)
  3. Fix XapiActorExt.distinctMerged function (commit: 39869b4) (details)
  4. Fix mistake on XapiStatementEntityDao get assignment progress function: incorrect use of group. (commit: 04eeca8) (details)
  5. Make assignment progress query test more rigorous. (commit: b0a5249) (details)
  6. Implement creation of an XapiGroup for students in a given class to enable assignments to work as expected. (commit: 7f5e45c) (details)
  7. Remove the app url argument from Learning Unit Detail screen. This should not be required. (commit: 5dfc66f) (details)
  8. Add GetXapiActivityForPublicationUseCase and related readme. (commit: 2be5b5d) (details)
  9. Update assignment recipe example. (commit: af3beb9) (details)
Commit 81f315480906410a35e706d6b9102c1e64076aaa by Mike Dawson
Fix XapiStatementEntityDao

The Xapi search query used Join XapiVerbEntity instead of left join. The XapiVerbEntity is only created when a verb has display properties.

This broke the query such that statements that used verbs that had no display properties would not be returned.
 (commit: 81f3154)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
Commit 2e51e61093b64abdb3ce834e8f8166cc86dc2eca by Mike Dawson
Fix XapiStatementEntityDao

The Xapi search query used Join XapiVerbEntity instead of left join. The XapiVerbEntity is only created when a verb has display properties.

This broke the query such that statements that used verbs that had no display properties would not be returned.
 (commit: 2e51e61)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/entities/XapiVerbEntity.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDb.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/composites/XapiStatementAndJsonEntities.kt (diff)
Commit 39869b40a763fc14c8e02094fe373e2b93accd8c by Mike Dawson
Fix XapiActorExt.distinctMerged function

DistinctMerged function was not handling identified groups correctly: the returned group member was not null even if it was null in the input. This caused the ActorDataSource to incorrectly remove all group members.
 (commit: 39869b4)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/xapi/ext/XapiActorExt.kt (diff)
Commit 04eeca8a1ead36288a2a1371e6a859324e142699 by Mike Dawson
Fix mistake on XapiStatementEntityDao get assignment progress function: incorrect use of group.
 (commit: 04eeca8)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/daos/XapiStatementEntityDao.kt (diff)
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/model/XapiVerb.kt (diff)
Commit b0a5249bb832437f50727267f631375474f1f233 by Mike Dawson
Make assignment progress query test more rigorous.
 (commit: b0a5249)
The file was modifiedrespect-datalayer-db/src/jvmTest/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDbTest.kt (diff)
Commit 7f5e45c59ec11eb38383a9d4c8e1b9ec84c576d6 by Mike Dawson
Implement creation of an XapiGroup for students in a given class to enable assignments to work as expected.
 (commit: 7f5e45c)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/enrollments/UpdateClazzStudentXapiGroupUseCase.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/invite/ApproveOrDeclineInviteRequestUseCase.kt (diff)
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/model/XapiVerb.kt (diff)
The file was modifiedrespect-datalayer-db/src/jvmTest/kotlin/world/respect/datalayer/db/school/xapi/XapiStatementsResourceDbTest.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/account/RespectAccountManager.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/ext/ClazzExt.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/ext/PersonExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/clazz/detail/ClazzDetailViewModel.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/xapi/XapiActorDataSourceDb.kt (diff)
The file was modifiedrespect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/invite/RedeemInviteUseCaseDb.kt (diff)
The file was modifiedrespect-server/src/main/kotlin/world/respect/server/ServerKoinModule.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
Commit 5dfc66f1f8e4d4a53f4fab55d95ac9b67aab7768 by Mike Dawson
Remove the app url argument from Learning Unit Detail screen. This should not be required.
 (commit: 5dfc66f)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/learningunit/detail/LearningUnitDetailScreen.kt (diff)
The file was addedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/opds/ext/OpdsPublicationExt.kt
The file was modifiedrespect-lib-opds-model/src/commonMain/kotlin/world/respect/lib/opds/model/OpdsPublicationExt.kt (diff)
The file was modifiedrespect-datalayer-http/src/commonMain/kotlin/world/respect/datalayer/http/school/opds/OpdsPublicationDataSourceHttp.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/opds/ext/ReadiumLinkExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/navigation/AppRoutes.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/opds/ext/OpdsFeedExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/detail/AssignmentDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/list/LearningUnitListViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/detail/LearningUnitDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/detail/AppsDetailViewModel.kt (diff)
The file was modifiedrespect-datalayer-db/src/commonMain/kotlin/world/respect/datalayer/db/school/adapters/AssignmentAdapter.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/LearningUnitSelection.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/launchapp/LaunchAppUseCase.kt (diff)
The file was modifiedrespect-lib-xapi-core/README_ASSIGNMENT_RECIPE.md (diff)
The file was modifiedrespect-lib-shared/src/androidMain/kotlin/world/respect/shared/domain/launchapp/LaunchAppUseCaseAndroid.kt (diff)
The file was modifiedrespect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/model/AssignmentLearningUnitRef.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/assignment/edit/AssignmentEditViewModel.kt (diff)
Commit 2be5b5d4888c7fcb11c26e55025123cbd0251a70 by Mike Dawson
Add GetXapiActivityForPublicationUseCase and related readme.
 (commit: 2be5b5d)
The file was addedrespect-lib-xapi-core/README_EXTENSION_PUBLICATION.md
The file was modifiedrespect-lib-xapi-core/src/commonMain/kotlin/world/respect/lib/xapi/OpenEelXapiConstants.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/opds/getxapiactivityid/GetXapiActivityForPublicationUseCase.kt
The file was modifiedrespect-lib-opds-model/src/commonMain/kotlin/world/respect/lib/opds/model/LangMapExt.kt (diff)
The file was modifiedrespect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt (diff)
Commit af3beb9f6048b7c6c72f3d45ce998dd5574fab03 by Mike Dawson
Update assignment recipe example.
 (commit: af3beb9)
The file was modifiedrespect-lib-xapi-core/README_ASSIGNMENT_RECIPE.md (diff)