Skip to content
Failed

Changes

Summary

  1. Updated maestro flows (details)
  2. Main tests ready (details)
  3. renamed the test (details)
  4. Added teardown to the tests (details)
  5. Add test name as a parameter to school_init.js (details)
  6. Added new tests (details)
  7. Moved failed tests to Flow_in_progress (details)
  8. Removed signup flow tests also added a test to login via link (details)
  9. Updated  the error (details)
  10. Updated  the school url (details)
  11. minor fix (details)
  12. Updated test description (details)
  13. Updated test description (details)
  14. Updated ReadMe (details)
  15. Updated ReadMe (details)
  16. Updated tests (details)
  17. Updated tests (details)
  18. Updated tests (details)
  19. Updated tests (details)
  20. Updated phone verification tests (details)
  21. Updated folder structure and passkey test added (details)
  22. refactor: Simplify image selection and remove unused constant (details)
  23. refactor: Resolve URLs to absolute paths in OPDS feed (details)
  24. refactor: Resolve URLs to be absolute in `AppsDetailViewModel` (details)
  25. feat: Resolve lesson image URLs to absolute paths (details)
  26. feat: Resolve lesson image URLs to absolute paths (details)
  27. refactor: Standardize variable name for publication (details)
  28. refactor: Centralize OPDS feed URL resolution, (details)
  29. updated test flows (details)
  30. updated phone number (details)
  31. updated phone number (details)
  32. updated phone number (details)
  33. updated valid phone number (details)
  34. Add testtag for phone number country code and number field. (details)
  35. added countrycode id (details)
  36. deleted descriptions (details)
  37. Update issue templates (details)
  38. Update issue templates (details)
  39. Update issue templates (details)
  40. Delete .github/ISSUE_TEMPLATE/custom.md (details)
  41. Create task_card.md (details)
  42. Tidyup resolve function. (details)
  43. Tidyup LearningUnitDetailViewModel to use resolve function (details)
The file was removed.maestro/flows-in-progress/001_003_student_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows-in-progress/003_create_classes_test.yaml
The file was removed.maestro/flows-in-progress/001_002_Parent_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows-in-progress/001_004_user_login_via_invite_link_and_browse_lessons_test.yaml
The file was added.maestro/flows/003_create_classes_test.yaml
The file was removed.maestro/flows-in-progress/001_001_user_login_to _app_with_school_name_test.yaml
The file was added.maestro/flows/001_003_student_user_join_class_using_invitecode_test.yaml
The file was modifiedrespect-test-end-to-end/test-description/001_browse_lessons_test_description.md (diff)
The file was added.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml
The file was added.maestro/flows/001_004_user_login_via_invite_link_and_browse_lessons_test.yaml
The file was added.maestro/flows/001_001_user_login_to_app_with_school_name_test.yaml
The file was modified.maestro/flows/subflows/school_admin_login_flow.yaml (diff)
The file was modified.maestro/flows/001_004_user_login_via_invite_link_and_browse_lessons_test.yaml (diff)
The file was removed.maestro/flows/001_003_student_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows/001_002_Parent_user_join_class_using_invitecode_test.yaml
The file was added.maestro/flows-in-progress/001_002_Parent_user_join_class_using_invitecode_test.yaml
The file was modified.maestro/flows/003_create_classes_test.yaml (diff)
The file was added.maestro/flows-in-progress/001_003_student_user_join_class_using_invitecode_test.yaml
The file was modified.maestro/flows/000_000_hello_world.yaml (diff)
The file was modified.maestro/flows/001_001_user_login_to_app_with_school_name_test.yaml (diff)
The file was removed.maestro/flows/003_create_classes_test.yaml
The file was added.maestro/flows/003_001_create_classes_test.yaml
Commit 526bcc79257a95ed595a75d32095e3be8b6d0beb by Pooja Ravi
Added teardown to the tests
The file was modified.maestro/flows/003_001_create_classes_test.yaml (diff)
The file was modified.maestro/flows/001_001_user_login_to_app_with_school_name_test.yaml (diff)
The file was modified.maestro/flows/001_004_user_login_via_invite_link_and_browse_lessons_test.yaml (diff)
The file was modified.maestro/flows-in-progress/001_002_Parent_user_join_class_using_invitecode_test.yaml (diff)
The file was modified.maestro/flows-in-progress/001_003_student_user_join_class_using_invitecode_test.yaml (diff)
Commit 96e3b4a78e8f877f6525ff4e4d6690d2d49be4ac by Mike Dawson
Add test name as a parameter to school_init.js
The file was modified.maestro/flows/001_001_user_login_to_app_with_school_name_test.yaml (diff)
The file was modified.maestro/flows/001_004_user_login_via_invite_link_and_browse_lessons_test.yaml (diff)
The file was modified.maestro/flows/003_001_create_classes_test.yaml (diff)
The file was added.maestro/flows/002_001_user_add_app_via_link_and_browse_lessons_test.yaml
The file was removed.maestro/flows/001_004_user_login_via_invite_link_and_browse_lessons_test.yaml
The file was added.maestro/flows/001_002_user_login_to_app_with_link_provided_by_admin_test.yaml
The file was added.maestro/flows/001_004_teacher_user_join_class_using_invitecode_test.yaml
Commit 0e3318e3a6e0403db39865022c00cf4c09cb2e9e by Pooja Ravi
Moved failed tests to Flow_in_progress
The file was added.maestro/flows-in-progress/001_004_teacher_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows/001_004_teacher_user_join_class_using_invitecode_test.yaml
The file was added.maestro/flows-in-progress/001_002_user_login_to_app_with_link_provided_by_admin_test.yaml
The file was removed.maestro/flows/001_002_user_login_to_app_with_link_provided_by_admin_test.yaml
Commit 5746fef6ec7e5b5285d25c899a6c49c2e6382b21 by Pooja Ravi
Removed signup flow tests also added a test to login via link
The file was removed.maestro/flows-in-progress/001_002_Parent_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows-in-progress/001_002_user_login_to_app_with_link_provided_by_admin_test.yaml
The file was added.maestro/flows/001_002_user_login_to_app_with_link_provided_by_admin_test.yaml
The file was removed.maestro/flows-in-progress/001_003_student_user_join_class_using_invitecode_test.yaml
The file was removed.maestro/flows-in-progress/001_004_teacher_user_join_class_using_invitecode_test.yaml
The file was modified.maestro/flows/001_002_user_login_to_app_with_link_provided_by_admin_test.yaml (diff)
Commit 5df16aebe81384af63640b6c26b2747957280055 by Pooja Ravi
Updated  the school url
The file was modified.maestro/flows/002_001_user_add_app_via_link_and_browse_lessons_test.yaml (diff)
The file was modified.maestro/flows/001_002_user_login_to_app_with_link_provided_by_admin_test.yaml (diff)
The file was modified.maestro/flows/001_002_user_login_to_app_with_link_provided_by_admin_test.yaml (diff)
Commit 2fe54bd23b973d565ae939f6bb7f337add2b1411 by Pooja Ravi
Updated test description
The file was modifiedrespect-test-end-to-end/README.md (diff)
The file was addedrespect-test-end-to-end/test-description/001_003_admin_create_a_person_and_validate_user_login_and_credentials_test_description.md
The file was addedrespect-test-end-to-end/test-description/001_002_admin_add_class_and_members_test_description.md
The file was addedrespect-test-end-to-end/test-description/001_001_admin_login_with_school_url_test_description.md
The file was removedrespect-test-end-to-end/test-description/004_create_report_test_description.md
The file was addedrespect-test-end-to-end/test-description/001_004_add_app_via_link_and_browse_lessons_test_description.md
The file was removedrespect-test-end-to-end/test-description/001_browse_lessons_test_description.md
Commit 06e409f67112f93a3e5dc1e3d7d82b50feb31997 by Pooja Ravi
Updated test description
The file was modifiedrespect-test-end-to-end/test-description/001_003_admin_create_a_person_and_validate_user_login_and_credentials_test_description.md (diff)
The file was modifiedrespect-test-end-to-end/README.md (diff)
The file was modifiedrespect-test-end-to-end/README.md (diff)
The file was removed.maestro/flows/001_002_user_login_to_app_with_link_provided_by_admin_test.yaml
The file was removed.maestro/flows/002_001_user_add_app_via_link_and_browse_lessons_test.yaml
The file was removed.maestro/flows/001_001_user_login_to_app_with_school_name_test.yaml
The file was modifiedrespect-test-end-to-end/test-description/001_004_add_app_via_link_and_browse_lessons_test_description.md (diff)
The file was removed.maestro/flows/003_001_create_classes_test.yaml
The file was added.maestro/flows/001_003_admin_create_a_person_and_validate_user_login_and_credentials_test.yaml
The file was added.maestro/flows/001_004_add_app_via_link_and_browse_lessons_test.yaml
The file was added.maestro/flows/001_001_admin_login_with_school_url_test.yaml
The file was modified.maestro/flows/001_003_admin_create_a_person_and_validate_user_login_and_credentials_test.yaml (diff)
The file was modified.maestro/flows/001_003_admin_create_a_person_and_validate_user_login_and_credentials_test.yaml (diff)
The file was modified.maestro/flows/001_003_admin_create_a_person_and_validate_user_login_and_credentials_test.yaml (diff)
Commit b18b14ebbc8f5fa16c39ab7c2c10a99a776359b0 by Pooja Ravi
Updated phone verification tests
The file was modified.maestro/flows/001_003_admin_create_a_person_and_validate_user_login_and_credentials_test.yaml (diff)
Commit 19da568d4bcc5c07093a550c5e09202b4e8ac304 by Pooja Ravi
Updated folder structure and passkey test added
The file was added.maestro/flow-passkey/subflows/school_admin_login_flow.yaml
The file was added.maestro/flows/scripts/teardown.js
The file was added.maestro/flow-passkey/subflows/choose_passkey_prompt_cancel.yaml
The file was added.maestro/flow-passkey/subflows/save_password_prompt_cancel.yaml
The file was modified.maestro/flows/001_001_admin_login_with_school_url_test.yaml (diff)
The file was added.maestro/flows/scripts/school_init.js
The file was modified.maestro/flows/000_000_hello_world.yaml (diff)
The file was added.maestro/flow-passkey/subflows/create_passkey_to_sign_in_flow.yaml
The file was added.maestro/flow-passkey/subflows/school_user_passkey_login_flow.yaml
The file was removed.maestro/flows/subflows/setDate.js
The file was modified.maestro/flows/001_004_add_app_via_link_and_browse_lessons_test.yaml (diff)
The file was removed.maestro/flows/subflows/teardown.js
The file was modified.maestro/flows/001_003_admin_create_a_person_and_validate_user_login_and_credentials_test.yaml (diff)
The file was added.maestro/flow-passkey/scripts/teardown.js
The file was added.maestro/flow-passkey/scripts/school_init.js
The file was added.maestro/flow-passkey/scripts/setDate.js
The file was added.maestro/flow-passkey/subflows/choose_passkey_prompt.yaml
The file was added.maestro/flows/scripts/setDate.js
The file was added.maestro/flow-passkey/001_Passkey_test.yaml
The file was added.maestro/flow-passkey/subflows/get_started_select_school_by_name.yaml
The file was removed.maestro/flows/subflows/school_init.js
Commit 804918720688c1622c4e4092965593fca71f10c4 by mandvi.verma
refactor: Simplify image selection and remove unused constant

This commit refactors how publication images are selected across multiple screens, simplifying the logic to use the first available image instead of searching for a specific image type.

The `IMAGE` constant (`"image/png"`) in `LearningUnitDetailViewModel` was removed as it was no longer needed.

Key changes:
- In `LearningUnitListScreen.kt`, `AppsDetailScreen.kt`, and `LearningUnitDetailScreen.kt`, the image selection logic is updated from `find { it.type?.contains(IMAGE) == true }` to `firstOrNull()`.
- The unused `IMAGE` constant and its companion object have been removed from `LearningUnitDetailViewModel.kt`.
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/learningunit/detail/LearningUnitDetailScreen.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/detail/LearningUnitDetailViewModel.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/apps/detail/AppsDetailScreen.kt (diff)
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/learningunit/list/LearningUnitListScreen.kt (diff)
Commit 0f28f82d80ba05de4797e162eb88a50f9b31386f by mandvi.verma
refactor: Resolve URLs to absolute paths in OPDS feed

The changes apply to `navigation`, `publications`, and `groups` within the feed, making sure that all `href` attributes in links, images, and alternates are converted to full, absolute URLs.
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/list/LearningUnitListViewModel.kt (diff)
Commit e1f4b131b1761e10eb3a847fe72675b2ed26f0a7 by mandvi.verma
refactor: Resolve URLs to be absolute in `AppsDetailViewModel`

This commit updates the `AppsDetailViewModel` to resolve relative URLs from the manifest to absolute URLs.
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/detail/AppsDetailViewModel.kt (diff)
Commit 0c4f1863bd136054a4b5faf1da985effb4463935 by mandvi.verma
feat: Resolve lesson image URLs to absolute paths

This commit updates the `LearningUnitDetailViewModel` to resolve relative image URLs to absolute URLs when fetching lesson details.
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/detail/LearningUnitDetailViewModel.kt (diff)
Commit 196e34441fc24066ead47d57a706e130fd419dac by mandvi.verma
feat: Resolve lesson image URLs to absolute paths

This commit updates the `LearningUnitDetailViewModel` to resolve relative image URLs to absolute URLs when fetching lesson details.
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/list/LearningUnitListViewModel.kt (diff)
Commit 168f3a57475cce7e963728ce3adde7c126d5ace5 by mandvi.verma
refactor: Standardize variable name for publication

This commit renames the local variable from `pub` to `publication` for better clarity and consistency when iterating over publication lists.
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/detail/AppsDetailViewModel.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/list/LearningUnitListViewModel.kt (diff)
Commit 50a0950973e0e08f8228c8a7698cce7b207bf285 by mandvi.verma
refactor: Centralize OPDS feed URL resolution,
removing duplicated code and simplifying the view models.

Key changes:
- A new `OpdsFeed.resolve(baseUrl: Url)` extension function has been created in `OpdsFeedExt.kt` to handle the resolution of all relative URLs within an `OpdsFeed` object (including publications, navigation links, and groups).
- `LearningUnitListViewModel` now uses `result.data.resolve(route.opdsFeedUrl)` to process the feed data, simplifying the logic for updating the UI state.
- `AppsDetailViewModel` has been similarly updated to use `result.data.resolve(route.manifestUrl)`.
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/detail/AppsDetailViewModel.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/OpdsFeedExt.kt
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/list/LearningUnitListViewModel.kt (diff)
The file was removed.maestro/flows/001_004_add_app_via_link_and_browse_lessons_test.yaml
The file was added.maestro/flow-passkey/006_user_signup_using_passkey_test.yaml
The file was removed.maestro/flows-in-progress/004_create_report_test.yaml
The file was removed.maestro/flows/001_001_admin_login_with_school_url_test.yaml
The file was modified.maestro/flows/subflows/school_admin_login_flow.yaml (diff)
The file was removed.maestro/flows/001_003_admin_create_a_person_and_validate_user_login_and_credentials_test.yaml
The file was added.maestro/flows/002_browse_lessons_test.yaml
The file was modified.maestro/flows/scripts/setDate.js (diff)
The file was added.maestro/flows/001_003_login_using_school_link_test.yaml
The file was added.maestro/flows/003_admin_user_assigns_assignment_to_a_class_test.yaml
The file was added.maestro/flows/subflows/save_password_prompt_cancel.yaml
The file was added.maestro/flows/001_002_add_user_direct_test.yaml
The file was modified.maestro/flows/000_000_hello_world.yaml (diff)
The file was removed.maestro/flow-passkey/001_Passkey_test.yaml
The file was added.maestro/flows/subflows/admin_add_app_and_teacher.yaml
The file was added.maestro/flows-in-progress/001_001_invite_using_invite_code_test.yaml
The file was modified.maestro/flows/001_002_add_user_direct_test.yaml (diff)
The file was modified.maestro/flows/001_002_add_user_direct_test.yaml (diff)
The file was modified.maestro/flows/001_002_add_user_direct_test.yaml (diff)
Commit d37f3eff807688dc6154f81df03eefb4252c1759 by Pooja Ravi
updated valid phone number
The file was modified.maestro/flows/001_002_add_user_direct_test.yaml (diff)
Commit 6d47100e5457f3506a49e09c5512b7616dcb1f67 by Mike Dawson
Add testtag for phone number country code and number field.
The file was modifiedrespect-app-compose/src/commonMain/kotlin/world/respect/app/view/person/edit/PersonEditScreen.kt (diff)
The file was modified.maestro/flows/001_002_add_user_direct_test.yaml (diff)
The file was removedrespect-test-end-to-end/test-description/001_001_admin_login_with_school_url_test_description.md
The file was removedrespect-test-end-to-end/test-description/001_004_add_app_via_link_and_browse_lessons_test_description.md
The file was removedrespect-test-end-to-end/test-description/001_002_admin_add_class_and_members_test_description.md
The file was removedrespect-test-end-to-end/test-description/001_003_admin_create_a_person_and_validate_user_login_and_credentials_test_description.md
Commit 1445355164cc0033360adac4043cf5fcec8605ba by noreply
Update issue templates
The file was added.github/ISSUE_TEMPLATE/bug_report.md
Commit 311bccb4e44057c47193baa86a059aa5e246697a by noreply
Update issue templates
The file was added.github/ISSUE_TEMPLATE/feature_request.md
Commit 32bea4025f3296fc84851e5045ef78a26343fb2a by noreply
Update issue templates
The file was added.github/ISSUE_TEMPLATE/custom.md
Commit 415a850711acd9e8416e725f992e51c73405436d by noreply
Delete .github/ISSUE_TEMPLATE/custom.md
The file was removed.github/ISSUE_TEMPLATE/custom.md
The file was added.github/ISSUE_TEMPLATE/task_card.md
Commit 3e7ac41bfc3a5172b6d1de31f7aec5e4acab12fc by Mike Dawson
Tidyup resolve function.

Use try/catch on feed resolve to log instead of crashing directly (as a validator would catch it).
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/OpdsFeedExt.kt (diff)
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/detail/AppsDetailViewModel.kt (diff)
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/OpdsPublicationExt.kt
The file was addedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/util/ext/ReadiumLinkExt.kt
Commit 1b0c73b003af6830e5523423a78c001755946385 by Mike Dawson
Tidyup LearningUnitDetailViewModel to use resolve function
The file was modifiedrespect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/detail/LearningUnitDetailViewModel.kt (diff)